Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winkel Tripel projection - high geometry simplification at low scale #36898

Closed
domlysz opened this issue Jun 2, 2020 · 4 comments · Fixed by #37092
Closed

Winkel Tripel projection - high geometry simplification at low scale #36898

domlysz opened this issue Jun 2, 2020 · 4 comments · Fixed by #37092
Assignees
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Projections/Transformations Related to coordinate reference systems or coordinate transformation Vectors Related to general vector layer handling (not specific data formats)

Comments

@domlysz
Copy link

domlysz commented Jun 2, 2020

Describe the bug

When using the Winkel Tripel projection at low scale, feature are displayed as simplified tetragone instead of full geometry. Screenshoots bellow :

image

image

How to Reproduce

  • Load a world dataset like Natural Earth
  • set up the project's projection to Winkel Tripel (EPSG 54042)
  • zoom back to see the whole world in the map window and the geometry simplification will appears

QGIS and OS versions

QGIS 3.13, GDAL 3.2, PROJ 7.1, bug appears both on Windows and Linux

Additional context

@domlysz domlysz added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Jun 2, 2020
@gioman
Copy link
Contributor

gioman commented Jun 2, 2020

@domlysz

layer properties > rendering > simplify geometry (to disable)

@domlysz
Copy link
Author

domlysz commented Jun 2, 2020

that's it ! sorry to annoy the team with an invalid bug report.

Have a nice day

@domlysz domlysz closed this as completed Jun 2, 2020
@nirvn
Copy link
Contributor

nirvn commented Jun 2, 2020

I don't know that this is not a bug here. Disabling the simplification is merely a workaround to not suffer from what appears to be a bug here.

@nyalldawson , thoughts?

@nyalldawson
Copy link
Collaborator

I think it's a bug -- we should automatically disable the simplification when this situation occurs

@nyalldawson nyalldawson reopened this Jun 3, 2020
@gioman gioman added Projections/Transformations Related to coordinate reference systems or coordinate transformation Vectors Related to general vector layer handling (not specific data formats) labels Jun 4, 2020
@nyalldawson nyalldawson self-assigned this Jun 10, 2020
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Jun 11, 2020
More numerically stable in the case of massive rectangles.

This is the ultimate cause behind qgis#36898 -- during rendering of the
worldwide layer in Winkel Tripel the inverse transform fails, so
the renderer sets a "maximal" filter extent for the layer (+/- double
max). The previous method for calculating the rectangles center would
fail, because it would overflow. The new method handles this case
and correctly returns 0,0.

Fixes bounding boxes show incorrectly when simplication is enabled
for a layer in certain projections.

Fixes qgis#36898
Refs qgis#30686 (partial fix -- this report includes two different bugs)
nyalldawson added a commit that referenced this issue Jun 11, 2020
More numerically stable in the case of massive rectangles.

This is the ultimate cause behind #36898 -- during rendering of the
worldwide layer in Winkel Tripel the inverse transform fails, so
the renderer sets a "maximal" filter extent for the layer (+/- double
max). The previous method for calculating the rectangles center would
fail, because it would overflow. The new method handles this case
and correctly returns 0,0.

Fixes bounding boxes show incorrectly when simplication is enabled
for a layer in certain projections.

Fixes #36898
Refs #30686 (partial fix -- this report includes two different bugs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Projections/Transformations Related to coordinate reference systems or coordinate transformation Vectors Related to general vector layer handling (not specific data formats)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants