Improve method for calculation of rectangle centers #37092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More numerically stable in the case of massive rectangles. This is the ultimate cause behind qgis#36898 -- during rendering of the worldwide layer in Winkel Tripel the inverse transform fails, so the renderer sets a "maximal" filter extent for the layer (+/- double max). The previous method for calculating the rectangles center would fail, because it would overflow. The new method handles this case and correctly returns 0,0. Fixes bounding boxes show incorrectly when simplication is enabled for a layer in certain projections. Fixes qgis#36898 Refs qgis#30686 (partial fix -- this report includes two different bugs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More numerically stable in the case of massive rectangles.
This is the ultimate cause behind #36898 -- during rendering of the
worldwide layer in Winkel Tripel the inverse transform fails, so
the renderer sets a "maximal" filter extent for the layer (+/- double
max). The previous method for calculating the rectangles center would
fail, because it would overflow. The new method handles this case
and correctly returns 0,0.
Fixes bounding boxes show incorrectly when simplication is enabled
for a layer in certain projections.
Fixes #36898
Refs #30686 (partial fix -- this report includes two different bugs)