Db manager does not correctly retrieve the ssl mode of postgreSQL connections

[FERRATON]

It's all in the title!

the cause of the error is on line 87 in
...\db_manager\db_plugins\postgis\plugin.py

I suggest replacing
try:
sslmode = settings.value("sslmode", QgsDataSourceUri.SslPrefer, type=int)
except TypeError:
sslmode = QgsDataSourceUri.SslPrefer
by
sslmode = settings.enumValue("sslmode", QgsDataSourceUri.SslPrefer)

[gioman]

I suggest replacing
try:
sslmode = settings.value("sslmode", QgsDataSourceUri.SslPrefer, type=int)
except TypeError:
sslmode = QgsDataSourceUri.SslPrefer
by
sslmode = settings.enumValue("sslmode", QgsDataSourceUri.SslPrefer)

@FERRATON can you propose a patch via PR?

[FERRATON]

I'm sorry, I'm not familiar with the process.
Could someone do it for me?

[gioman]

Could someone do it for me?

@FERRATON let's ask first a developer if this patch is correct first. @elpaso what do think about?

[elpaso]

Could someone do it for me?

@FERRATON let's ask first a developer if this patch is correct first. @elpaso what do think about?

Note that I'm commenting on the patch only, I didn't investigate the original issue.

I think that the patch is wrong: given the following configuration (SslDisable):

connections\docker%208.4\sslmode=1

QgsDataSourceUri.SslPrefer
Out[4]: 0

QgsDataSourceUri.SslDisable
Out[6]: 1

settings.beginGroup('/PostgreSQL/connections/docker 8.4')

settings.value("sslmode", QgsDataSourceUri.SslPrefer)
Out[8]: 1   # this is the expected value

settings.enumValue("sslmode", QgsDataSourceUri.SslPrefer)
Out[9]: 0  # this is wrong!

CC @3nids may know more about how this enumValue() is supposed to work.

[FERRATON]

for me (QGIS 3.10 windows) sslmode is not stored as an integer in QGIS3.ini but for example as :
connections\geobase_snum_etienne_lousteau_admin\sslmode=SslDisable

settings.value("sslmode", QgsDataSourceUri.SslPrefer) return 'SslDisable'
settings.enumValue("sslmode", QgsDataSourceUri.SslPrefer) return 1

[3nids]

connections\docker%208.4\sslmode=1

should be

connections\docker%208.4\sslmode=SslPrefer

[elpaso]

Ok, so the patch looks good and we have a bug somewhere because I didn't forge connections\docker%208.4\sslmode=1 but I've just taken it from my QGIS.ini.

[elpaso]

Update: I've found from where my sslmode=1 came from, see linked PR.

[FERRATON]

so could someone please pass the patch for ... \ db_manager \ db_plugins \ postgis \ plugin.py ?

[github-actions]

The QGIS project highly values your report and would love to see it addressed. However, this issue has been left in feedback mode for the last 14 days and is being automatically marked as "stale".
If you would like to continue with this issue, please provide any missing information or answer any open questions. If you could resolve the issue yourself meanwhile, please leave a note for future readers with the same problem and close the issue.
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this issue.
If there is no further activity on this issue, it will be closed in a week.

[gioman]

so could someone please pass the patch for ... \ db_manager \ db_plugins \ postgis \ plugin.py ?

@FERRATON do you mean create the pull request?

[FERRATON]

Yes if it's possible. I don't have the experience to do it myself yet.

[Gustry]

If it's short, you can edit straight from GitHub website, it will create the commit and PR for you.
There is a pen on each files.

[FERRATON]

All right, thank you.
I see that the proposed change has already been pushed in the master and in version 3.16.
I have proposed a PR for 3.10

[gioman]

I see that the proposed change has already been pushed in the master and in version 3.16.

@FERRATON closing then?

[github-actions]

The QGIS project highly values your report and would love to see it addressed. However, this issue has been left in feedback mode for the last 14 days and is being automatically marked as "stale".
If you would like to continue with this issue, please provide any missing information or answer any open questions. If you could resolve the issue yourself meanwhile, please leave a note for future readers with the same problem and close the issue.
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this issue.
If there is no further activity on this issue, it will be closed in a week.

[github-actions]

While we hate to see this happen, this Issue has been automatically closed because it has not had any activity in the last 42 days despite being marked as feedback. If this issue should be reconsidered, please follow the guidelines in the previous comment and reopen this issue.
Or, if you have any further questions, there are also further support channels that can help you.