Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping unknown layer type circle in vector tiles #41529

Closed
nicogodet opened this issue Feb 12, 2021 · 17 comments · Fixed by #41584
Closed

Skipping unknown layer type circle in vector tiles #41529

nicogodet opened this issue Feb 12, 2021 · 17 comments · Fixed by #41584
Assignees
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Vector tiles

Comments

@nicogodet
Copy link
Member

Describe the bug

The national french institute of geography (IGN) provides a vector tile layer -> https://vectortiles.ign.fr/

Some entities are not recognize because of there type "circle".
image
image

Is it a bug, missing feature ?
Should I report this to the provider directly (dunnow if I can) ?

How to Reproduce

  1. Add a new vector tile connection:
  1. Add the layer to project.
  2. See warnings

QGIS and OS versions

Qgis 3.16.3 Win10

Additional context

@nicogodet nicogodet added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Feb 12, 2021
@elpaso
Copy link
Contributor

elpaso commented Feb 12, 2021

I've just tested this on QGIS master on Linux and I didn't see any warning.

@elpaso
Copy link
Contributor

elpaso commented Feb 12, 2021

Can you test a nightly build on windows and see if the issue is still there?

@elpaso elpaso added the Feedback Waiting on the submitter for answers label Feb 12, 2021
@nicogodet
Copy link
Member Author

Tested on Master windows and same issue.
QGIS 33119ca

@elpaso elpaso added the Windows Related to Windows operating system label Feb 12, 2021
@elpaso
Copy link
Contributor

elpaso commented Feb 12, 2021

Ok, so to confirm that it's windows only (wierd though).

@nicogodet
Copy link
Member Author

nicogodet commented Feb 12, 2021

Tested on linux too with master and I reproduce the issue.
Fresh install, fresh profile
QGIS 7edd999

@elpaso
Copy link
Contributor

elpaso commented Feb 12, 2021

Ok, let's remove the windows tag. It's wierd I cannot see the warning though.

@elpaso elpaso removed Feedback Waiting on the submitter for answers Windows Related to Windows operating system labels Feb 12, 2021
@nicogodet
Copy link
Member Author

nicogodet commented Feb 12, 2021

Let's try something.

Zoom to coordinates

  • EPSG:2154 : 404936.8,6265925.6

  • WGS84 : -0.643611,43.431146

You should see an electrical line and as you don't any warnings, you should be able to see electric pylons
An image of WMS server that render the vector tiles.
image
You can see the pylon and a water point (blue circle)

An image of what I see on the vector tile layer.
image
No pylon, no blue circle.

@elpaso
Copy link
Contributor

elpaso commented Feb 12, 2021

I see no dots/circles and no warnings, but there is a network error in the logs. I'm using a 4K display (the @2x in the log makes me think that it might matter).

immagine

@nyalldawson
Copy link
Collaborator

I'm 99% sure we never added support for circle conversion, simply because we couldn't find ant styles which utilised it at the time 😝

@nicogodet
Copy link
Member Author

That would explain my warnings 😃

I have the network warning too and i'm not using a 4K display but I don't think it's related to current issue.

@gioman gioman changed the title [Vector Tiles] Skipping unknown layer type circle Skipping unknown layer type circle in vector tyle Feb 12, 2021
@agiudiceandrea
Copy link
Contributor

agiudiceandrea commented Feb 12, 2021

Hi @nicogodet I tried the layer using QGIS 3.16.3 on Windows 7 64 bit but I don't see any of the errors you reported.
I only see the warning "Error transferring https://vectortiles.ign.fr/demonstrateur/sprite/PlanIgn@2x.json - server replied: Not Found" previously reported by @elpaso (I'm not using a 4K display).

@nicogodet
Copy link
Member Author

Can you see circles for pylons and water point #41529 (comment) ?

You can identify the features but they are not rendered (missing circle implementation as @nyalldawson said before).

Why I have warnings and not you ?

@agiudiceandrea
Copy link
Contributor

When I add the layer with the style URL, the electric pylons circles and the water point circle are not rendered
image

When I add the layer without the style URL, the electric pylons circles and the water point circle are rendered
image

@nicogodet
Copy link
Member Author

I still not understand why it raises warnings here (3 differents computers, 3.16, master, windows, linux, fresh profile, ...).
On your first screen it's clear that those features are not rendered and if you look to json style, it corresponds to circle.

        {
            "id": "bati ponctuel infrastructure - pylone électrique",
            "type": "circle",
            "source": "plan_ign",
            "source-layer": "bati_ponc",
            "layout": {
                "visibility": "visible"
            },
            "filter": ["==","symbo","PYLONE_ELEC"],
            "paint": {
                "circle-radius" : {
                    "stops": [[13, 1], [17, 2]]
                },
                "circle-color" : "#000000"
            }
        },

@agiudiceandrea
Copy link
Contributor

agiudiceandrea commented Feb 13, 2021

I still not understand why it raises warnings here (3 differents computers, 3.16, master, windows, linux, fresh profile, ...).

I found the reason...
If the vector tile layer is added using the "Data Source Manager" then only the warning "Error transferring https://vectortiles.ign.fr/demonstrateur/sprite/PlanIgn@2x.json - server replied: Not Found" is displayed.

While, adding the layer using the Browse Panel, the warning "Vector tiles : Style could not be completely converted" with the additional details

The following warnings were generated while converting the vector tile style:
bati ponctuel hydrographique - Chateau d'eau: Skipping unknown layer type circle
bati ponctuel hydrographique - Réservoir d'eau: Skipping unknown layer type circle
bati ponctuel infrastructure - pylone électrique: Skipping unknown layer type circle
hydro ponctuel: Skipping unknown layer type circle
routier ponctuel - peage ponctuel: Skipping unknown layer type circle

are also displayed.

Anyway the result is the same: some features are not rendered.

@nicogodet nicogodet changed the title Skipping unknown layer type circle in vector tyle Skipping unknown layer type circle in vector tiles Feb 13, 2021
@PeterPetrik PeterPetrik self-assigned this Feb 15, 2021
@PeterPetrik
Copy link
Contributor

I can fix this is noone is working at it?

@nyalldawson
Copy link
Collaborator

Thanks @PeterPetrik -- no-one is working on it yet.

PeterPetrik added a commit to PeterPetrik/QGIS that referenced this issue Feb 16, 2021
nyalldawson pushed a commit that referenced this issue Feb 19, 2021
* fix #41529: add circle vector tile layer support
github-actions bot pushed a commit that referenced this issue Feb 19, 2021
* fix #41529: add circle vector tile layer support
github-actions bot pushed a commit that referenced this issue Feb 19, 2021
* fix #41529: add circle vector tile layer support
nyalldawson pushed a commit that referenced this issue Feb 20, 2021
* fix #41529: add circle vector tile layer support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Vector tiles
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants