add circle vector tile layer support #41584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nyalldawson not able to find any unittests for this part of code, shall I create a new tests for this or is it ok to go without tests? |
|
It seems small compared to rendered circle on ign website. https://geoservices.ign.fr/documentation/services_betas/vecteur-tuile.html And some typo in your code "cicle" instead of "circle" |
They are all here: https://github.com/qgis/QGIS/blob/master/tests/src/python/test_qgsmapboxglconverter.py |
Probably a result of setting the qgis symbol size as the circle radius, when it needs the diameter |
nyalldawson
reviewed
Feb 17, 2021
nyalldawson
approved these changes
Feb 17, 2021
nyalldawson
added
backport release-3_18
and removed
Frozen
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2021
* fix #41529: add circle vector tile layer support
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2021
* fix #41529: add circle vector tile layer support
nyalldawson
pushed a commit
that referenced
this pull request
Feb 20, 2021
* fix #41529: add circle vector tile layer support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #41529