Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two OGR provider filtered layers with same source dataset don't restore proper feature count / extent on project reload #43361

Closed
nirvn opened this issue May 24, 2021 · 0 comments · Fixed by #43372
Closed

Two OGR provider filtered layers with same source dataset don't restore proper feature count / extent on project reload #43361

nirvn opened this issue May 24, 2021 · 0 comments · Fixed by #43372
Assignees
@rouault
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers Vectors Related to general vector layer handling (not specific data formats)

Comments

@nirvn
Copy link
Contributor

nirvn commented May 24, 2021

Problem is as follow: if you have two OGR provider layers with the same source dataset, and both are filtered, one will restore the wrong feature count and extent upon project load. Basically, one layer will have an unfiltered feature count and extent.

Simple test project:
ogr_bug.zip

Steps to reproduce:

  1. Load the above-attached project
  2. Notice both layers are filtered using the same string ("PROV_CODE" = 12)
  3. Check both layers' feature count, one will have the wrong (unfiltered) count
  4. Check both layers' extent, one will have the wrong (unfiltered) extent
@nirvn nirvn added Data Provider Related to specific vector, raster or mesh data providers Bug Either a bug report, or a bug fix. Let's hope for the latter! Vectors Related to general vector layer handling (not specific data formats) labels May 24, 2021
@rouault rouault self-assigned this May 24, 2021
rouault added a commit to rouault/QGIS that referenced this issue May 24, 2021
@rouault
[OGR provider] Fix conflict between layers using same OGR datasource …
fd2d8e5 
…and layer with subset strings (fixes qgis#43361)
@rouault rouault mentioned this issue May 24, 2021
Merged
nyalldawson pushed a commit that referenced this issue May 25, 2021
@rouault @nyalldawson
[OGR provider] Fix conflict between layers using same OGR datasource …
cf49d25 
…and layer with subset strings (fixes #43361)
@rouault rouault mentioned this issue May 25, 2021
Merged
rouault added a commit to rouault/QGIS that referenced this issue May 25, 2021
@rouault
[OGR provider] Fix conflict between layers using same OGR datasource …
f1b17c4 
…and layer with subset strings (fixes qgis#43361)
nyalldawson pushed a commit that referenced this issue May 26, 2021
@rouault @nyalldawson
[OGR provider] Fix conflict between layers using same OGR datasource …
e65a22a 
…and layer with subset strings (fixes #43361)
nyalldawson pushed a commit that referenced this issue May 31, 2021
@rouault @nyalldawson
[OGR provider] Fix conflict between layers using same OGR datasource …
0889d1b 
…and layer with subset strings (fixes #43361)
nyalldawson pushed a commit that referenced this issue Jun 14, 2021
@rouault @nyalldawson
[OGR provider] Fix conflict between layers using same OGR datasource …
d1ac81a 
…and layer with subset strings (fixes #43361)
nyalldawson pushed a commit that referenced this issue Jun 21, 2021
@rouault @nyalldawson
[OGR provider] Fix conflict between layers using same OGR datasource …
04215e5 
…and layer with subset strings (fixes #43361)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rouault rouault

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers Vectors Related to general vector layer handling (not specific data formats)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[OGR provider] Fix conflict between layers using same OGR datasource … rouault/QGIS
2 participants
@rouault @nirvn