Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing "Measure Bearing" or "Measure Angle" results dialog causes crash #46151

Closed
1 of 2 tasks
thayeray opened this issue Nov 22, 2021 · 24 comments · Fixed by #56202
Closed
1 of 2 tasks

Closing "Measure Bearing" or "Measure Angle" results dialog causes crash #46151

thayeray opened this issue Nov 22, 2021 · 24 comments · Fixed by #56202
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption macOS Map Tools Related to non-digitizing map tools

Comments

@thayeray
Copy link

What is the bug or the crash?

Using the "close" button on either the Measure Angle or Measure Bearing results dialog causes QGIS to crash. The close button for the Measure Bearing tool seems to always cause a crash. The Measure Angle tool may close correctly once or twice but the third time usually causes a crash. Note that the "red circle x" button does not cause a crash.****

Steps to reproduce the issue

  1. Activate the Measure Bearing or Measure Angle tool from either the toolbar or the View: Measure: Measure Bearing/Angle menu
  2. Start a measurement by clicking on the map canvas
    a. The results dialog appears, with the measurement
  3. Click on the "Close" button in the bottom right of the dialog.
  4. If that does not cause a crash continue to make measurements and using the "Close" button until a crash occurs.
  5. A crash is more likely to occur the first time when the tool is activated from the toolbar icon and using the Measure Bearing tool.

Versions

Both LTR (3.16.14) and current release (3.22.1).
3.14-Pi also crashes when closing the measure angle tool with the "red circle x" button, not the "Close" button.

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

  • I tried with a new QGIS profile

Additional context

Note this is all with the MacOS standard installers from QGIS.org.

@thayeray thayeray added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Nov 22, 2021
@thayeray
Copy link
Author

Not sure if this is related to the closed issue: Closing "measure angle" causes crash on multiple displays #23504

@thayeray
Copy link
Author

I also tried with a new user profile and see the same problems. Sorry for forgetting this step initially.

@gioman gioman added the Feedback Waiting on the submitter for answers label Nov 22, 2021
@gioman
Copy link
Contributor

gioman commented Nov 22, 2021

If that does not cause a crash continue to make measurements and using the "Close" button until a crash occurs.

@thayeray tried many times, but I wasn't able to make QGIS crash. This may be related to some other detail, like the project CRS.

@gioman
Copy link
Contributor

gioman commented Nov 22, 2021

Not sure if this is related to the closed issue: Closing "measure angle" causes crash on multiple displays #23504

@thayeray do you use multiple displays?

@uclaros
Copy link
Contributor

uclaros commented Nov 22, 2021

Can you also attach the crash's stack trace?

@thayeray
Copy link
Author

Thanks for your attention to this. @gioman I am not using multiple displays, but the issue seems to be the same/similar. For most of my testing I have been either measuring on a blank canvas which usually results in 'NaN' for the measurements, or adding OSM Standard from QuickMapServices so the project CRS is 4326 or 3857. For the older version 3.14 I added a layer in 2893 to a blank canvas. My system is older MacOS 10.13.6, my MacBook Pro Mid 2014 is vintage, but not yet obsolete.

@uclaros sample MacOS crash report is attached for both tools.
Opened new user profile: test2, closed window for my Default user, added a single 4326 layer to a blank canvas, measured bearing and clicked "close". This is from the current MacOS build of latest release (3.22.1):
measure_bearing_crash_new_user.txt

This is from the current MacOS build of latest release (3.22.1):
measure_bearing_crash.txt
This is from the current MacOS build of LTR (3.16.14):
measure_angle_crash.txt

@gioman
Copy link
Contributor

gioman commented Nov 22, 2021

So this is probably a macOS only issue (I cannot replicate on Windows or Linux).

@gioman gioman added macOS and removed Feedback Waiting on the submitter for answers labels Nov 22, 2021
@gioman
Copy link
Contributor

gioman commented Nov 22, 2021

For most of my testing I have been either measuring on a blank canvas which usually results in 'NaN' for the measurements,

Weird, a blank canvas still has a CRS and it still shows a measurement on Windows and Linux.

@Cranners47
Copy link

I can confirm this bug is still present in QGIS V3.26.1

I am having the same issue in where if I open the measure bearing tool, then click the 'close' button or the 'X' it crashes QGIS.

This is using Mac OS Monterey, V12.5 on an Intel based 2019 MacBook Pro.

QGIS version 3.26.1-Buenos Aires QGIS code revision b609df9
Qt version 5.15.2
Python version 3.9.5
GDAL/OGR version 3.3.2
PROJ version 8.1.1
EPSG Registry database version v10.028 (2021-07-07)
GEOS version 3.9.1-CAPI-1.14.2
SQLite version 3.35.2
PDAL version 2.3.0
PostgreSQL client version unknown
SpatiaLite version 5.0.1
QWT version 6.1.6
QScintilla2 version 2.11.5
OS version macOS 12.5
       
Active Python plugins
quick_map_services 0.19.29
ViewshedAnalysis 1.8
los_tools 0.5
Qgis2threejs 2.7.1
shapetools 3.4.6
processing 2.12.99
sagaprovider 2.12.99
grassprovider 2.12.99
db_manager 0.1.20
MetaSearch 0.3.6

QGIS version
3.26.1-Buenos Aires
QGIS code revision
b609df9ed4
Qt version
5.15.2
Python version
3.9.5
GDAL/OGR version
3.3.2
PROJ version
8.1.1
EPSG Registry database version
v10.028 (2021-07-07)
GEOS version
3.9.1-CAPI-1.14.2
SQLite version
3.35.2
PDAL version
2.3.0
PostgreSQL client version
unknown
SpatiaLite version
5.0.1
QWT version
6.1.6
QScintilla2 version
2.11.5
OS version
macOS 12.5

Active Python plugins
quick_map_services
0.19.29
ViewshedAnalysis
1.8
los_tools
0.5
Qgis2threejs
2.7.1
shapetools
3.4.6
processing
2.12.99
sagaprovider
2.12.99
grassprovider
2.12.99
db_manager
0.1.20
MetaSearch
0.3.6

@rawhead303
Copy link

I've had this problem for a while / several versions. Still happening now with macOS Ventura 13.2, and QGIS 3.28.2-Firenze. I get around it by not closing the dialog window when in angle or bearing mode. I can switch to "Measure Line" mode, and then I can safely close the dialog window without crashing. I can also confirm this only happens on my Mac (M1 Macbook Air), and not on Windows.

@MigBaron
Copy link

MigBaron commented Jun 6, 2023

Sill happening on 3.30.3-'s-Hertogenbosch with macOS 13.4 (iMac M1, 2021). I don't have a Windows so I can't say for this OS. Also, the advanced

@thibaut-kobold
Copy link

thibaut-kobold commented Jun 7, 2023

I am also encountering this issue. My current config in which the crash occurs:

QGIS version | 3.30.1-'s-Hertogenbosch | QGIS code revision | 447e8d717a
Qt version | 5.15.2
Python version | 3.9.5
GDAL/OGR version | 3.3.2
PROJ version | 8.1.1
EPSG Registry database version | v10.028 (2021-07-07)
GEOS version | 3.9.1-CAPI-1.14.2
SQLite version | 3.35.2
PDAL version | 2.3.0
PostgreSQL client version | unknown
SpatiaLite version | 5.0.1
QWT version | 6.1.6
QScintilla2 version | 2.11.5
OS version | macOS 13.4

@bheberlein
Copy link

I also get this on my MacBook M1 Max. Start measuring bearing, press Esc, it crashes. QGIS 3.30.2

@alexbruy alexbruy added Map Tools Related to non-digitizing map tools Crash/Data Corruption labels Oct 8, 2023
@bosmanoglu
Copy link

Hi all, I have the same issue using QGIS-LTR (3.28 Firenze). I tried to generate a log using the recommendation here to no avail... Here you can find the MacOS error report...

@kalkun
Copy link

kalkun commented Nov 25, 2023

Also on Mac using latest QGIS version: 3.34.0-Prizren either closing angle measure or bearing measure will crash QGIS. Not sure what the best approach for an error report as its not mentioned to get a stack trace on mac in the docs: https://qgis.org/en/site/getinvolved/development/bugreporting.html

@rawhead303
Copy link

rawhead303 commented Nov 25, 2023 via email

@kalkun
Copy link

kalkun commented Nov 27, 2023

I received this problem report.

@Matt704
Copy link

Matt704 commented Jan 10, 2024

The same is happening for me.

When I close the direction measurement window QGIS crashes every time.

Here my specs:
QGIS-Version
3.34.2-Prizren
macOS 14.1

Note from crash report:
PC register does not match crashing frame (0x0 vs 0x7FF89AD86A78)

Hope this will be fixed in the future.

@uclaros
Copy link
Contributor

uclaros commented Feb 6, 2024

Could someone building QGIS on a mac confirm that #56202 resolves the issue?

@thayeray
Copy link
Author

This does not fix the problem on my machine. I tried QGIS version 3.33.0-Master QGIS code revision 94d2f85, which I downloaded on 2/7/2024 from the QGIS-Mac-Packager repository of the QGIS Github page. I tried both measure angle and measure bearing with a user with all plugins turned off, and each time I tried to close the tool dialog, IT CRASHED QGIS every time. Please reopen this issue it is not fixed.

@nyalldawson
Copy link
Collaborator

@thayeray 3.33 is the wrong version. You need 3.35

@thayeray
Copy link
Author

I see now, the Mac-Packager stopped compiling nightlies back in August, didn't notice that it says passing but it doesn't say the date. I'll check this on Feb 24 when the PR comes out.

@thayeray
Copy link
Author

Thanks! Closing the angle or bearing measurement tool no longer crashes QGIS in the PR!

@nyalldawson
Copy link
Collaborator

Thanks for the confirmation @thayeray !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption macOS Map Tools Related to non-digitizing map tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.