Fix crash on measure angle/bearing tools #56202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uclaros
added
Bug
2 tasks
rouault
approved these changes
Feb 6, 2024
|
Just tested with 3.43.3 on MacOS, and it still crashes. Please disregard if the fix isn't yet incorporated into that version of QGIS. |
|
@Lugal-PCZ the fix was only merged 1 hour ago, it's definitely NOT in any released version of QGIS 🤣 |
|
Nice! I appreciate your hard work. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tools were trying to delete the dialog when the
rejectedsignal was fired, not giving it time to fire thefinishedsignal.Switching to using the
QDialog::finished()signal fixes that.I've tested this on Linux, it would be nice if someone could test this on a mac which seemed way more easy to reproduce.
Fixes #46151
Fixes #54773