Temporal Controller is missing last time step of NetCDF (or all meshes?)

[rduivenvoorde]

What is the bug or the crash?

Researching the use of netcdf ugrids and creating a tiny test netcdf with just 3 timesteps, after loading in QGIS, the TimeController just shows 2 timesteps.

Only when you manually change the Animation range to something longer, it will show all timesteps.

Reproducable with both a tiny nc ugrid or the MDAL test ugrid:
https://github.com/lutraconsulting/MDAL/blob/master/tests/data/ugrid/D-Flow1.2/bw_11_zonder_riviergrid_met_1dwtg_map.nc

Steps to reproduce the issue

Load this tiny ugrid in QGIS as mesh:

ugrid.zip

Make sure you use 'Step' '24 hours'
You will see there are just 2 steps possible:

While in ncdump you will see:

  time = 0, 24, 48 ;

step 0 has just 1 value 33
step 1 has 2 values 33, 44
step 3 has 2 values 44, 55

When opening the file you will see Animation range: 2020-01-01 00:00:00 - 2020-01-03 00:00:00
while data is:
"hours since 2020-01-01 00:00:00.0"
time = 0, 24, 48 ;

If you change the Animation range manually to 2020-01-03 01:00:00 (adding 1 hour) you will be able to see the last step

So I think it has something to do with Animation Range given?

Step 1

Step 2

Step 3 (ONLY after changing Animation Range):

Exact the same can be seen with the mdal test data:

https://github.com/lutraconsulting/MDAL/blob/master/tests/data/ugrid/D-Flow1.2/bw_11_zonder_riviergrid_met_1dwtg_map.nc

It has 23 steps:

 time = 658800, 660000, 661200, 662400, 663600, 664800, 666000, 667200,·
    668400, 669600, 670800, 672000, 673200, 674400, 675600, 676800, 678000,·
    679200, 680400, 681600, 682800, 684000, 685200 ;

But you can only do 22 steps (unless you add some time to the Animation Range)

Versions

QGIS version	3.25.0-Master	QGIS code revision	1af9c81
Qt version	5.15.2
Python version	3.10.4
GDAL/OGR version	3.4.3
PROJ version	9.0.0
EPSG Registry database version	v10.054 (2022-02-13)
GEOS version	3.10.2-CAPI-1.16.0
SQLite version	3.38.5
PostgreSQL client version	unknown
SpatiaLite version	5.0.1
QWT version	6.1.4
QScintilla2 version	2.11.6
OS version	Debian GNU/Linux bookworm/sid

QGIS version 3.25.0-Master QGIS code revision [1af9c81](https://github.com/qgis/QGIS/commit/1af9c8150c0) Qt version 5.15.2 Python version 3.10.4 GDAL/OGR version 3.4.3 PROJ version 9.0.0 EPSG Registry database version v10.054 (2022-02-13) GEOS version 3.10.2-CAPI-1.16.0 SQLite version 3.38.5 PostgreSQL client version unknown SpatiaLite version 5.0.1 QWT version 6.1.4 QScintilla2 version 2.11.6 OS version Debian GNU/Linux bookworm/sid

Supported QGIS version

• I'm running a supported QGIS version according to the roadmap.

New profile

• I tried with a new QGIS profile

Additional context

No response