Add includeEnd into the totalFrameCount game

[rduivenvoorde]

Layers with instantanous events (zero length, e.g. vector or mesh layers) missed the last events because totalFrameCount was off by one.

To fix the totalFrameCount, we add a microsecond to the temporal project extent, ONLY when there is a chance that there are any instantaneous events which are ON the temporal project extent.

We trigger the addition of the microsecond by going over alls layer and check for potential events ON the temporal project extent. If so we let the calculateTemporalRangeForProject return a QgsDateTimeRange which includes the end.

This fixes for example: #48942

To see it yourself, load both netcdf files from this zip.
3steps.zip
Both have 3 datasets but ugrid3timestepstart24.nc received just 2 steps.

This is also reproducable with a csv with instantanous events (without a length).

The drawback of this pull is that it sometimes adds one step extra...

THIS PR supersedes: #52857 which ALWAYS added the extra time step.
Personally I prefer that PR, as it is simpler.

[rduivenvoorde]

@nyalldawson what about this solution? I prefer #52857 for it's simplicity to be honest.
I do not know the use cases but the I prefer having one frame too much over one frame too few.
(All I is want is my data to be shown :-) so I can go on and add a mdalprovider related fix)

[rduivenvoorde]

Ping?

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.