Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitfeatures function #52145

Closed
2 tasks
Speed1987sS opened this issue Mar 8, 2023 · 6 comments · Fixed by #53526
Closed
2 tasks

Splitfeatures function #52145

Speed1987sS opened this issue Mar 8, 2023 · 6 comments · Fixed by #53526
Assignees
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore

Comments

@Speed1987sS
Copy link

What is the bug or the crash?

Before update I use version 3.24
I can use "splitfeatures" function to split 3Dpolyline and 3Dpolygon with z value created with result.
After update to 3.30, I split 3Dpolyline and 3Dpolygon, i get "0" z value with vertex i splited.
Can anyone help to fix it?

Steps to reproduce the issue

No

Versions

After3.24

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

  • I tried with a new QGIS profile

Additional context

No response

@Speed1987sS Speed1987sS added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Mar 8, 2023
@uclaros
Copy link
Contributor

uclaros commented Mar 8, 2023

Steps to reproduce the issue

No

Unfortunately, this doesn't help much in reproducing your issue. It would be appreciated if you could add some step-by-step instructions!

@agiudiceandrea
Copy link
Contributor

And please also add a sample layer.

@agiudiceandrea agiudiceandrea added the Feedback Waiting on the submitter for answers label Mar 8, 2023
@Speed1987sS
Copy link
Author

Speed1987sS commented Mar 9, 2023 via email

@Speed1987sS
Copy link
Author

Sample

@agiudiceandrea agiudiceandrea added Regression Something which used to work, but doesn't anymore Digitizing Related to feature digitizing map tools or functionality Processing Relating to QGIS Processing framework or individual Processing algorithms and removed Feedback Waiting on the submitter for answers labels Mar 9, 2023
@agiudiceandrea
Copy link
Contributor

agiudiceandrea commented Mar 9, 2023

@uclaros, I can confirm the issue on Windows using QGIS 3.28.4 and QGIS 3.30.0. The issue doesn't occur using QGIS 3.22.
The issue regards the "Split Features" tool in the Advanced Digitizing Toolbar and the Split with lines (native:splitwithlines) processing algorithm.

With the provided layers: the vertex added by the "Split Features" tool or the "Split with lines" algorithm between two consecutive vertices of the polygon perimeter, whose Z values are 20 an 22 respectively, has a Z value of 10.218 using QGIS 3.28 and 3.30, while it has a Z value of 20.436 using QGIS 3.22.

It seems the issue occurs splitting a polygon by a line and doesn't occur splitting a line by another line.

@troopa81 troopa81 self-assigned this Jun 15, 2023
troopa81 added a commit to troopa81/QGIS that referenced this issue Jun 20, 2023
@troopa81
Copy link
Contributor

troopa81 commented Jun 20, 2023

With the provided layers: the vertex added by the "Split Features" tool or the "Split with lines" algorithm between two consecutive vertices of the polygon perimeter, whose Z values are 20 an 22 respectively, has a Z value of 10.218 using QGIS 3.28 and 3.30, while it has a Z value of 20.436 using QGIS 3.22.

the proposed PR fix the map tool part.

Regarding the algorithm native:splitwithlines, if the splitting line have Z values then the Z value at the intersection will be the mean value between the interpolated Z values of the splitting line and the polygon edge, and IMHO it's perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants