Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DTiles: QGIS fails to render the transparency that Skyline's 3DTiles set to the floor tiles #55579

Closed
2 tasks
yanivday opened this issue Dec 12, 2023 · 10 comments · Fixed by #56303
Closed
2 tasks
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@yanivday
Copy link

What is the bug or the crash?

Skyline is a leading provider of 3D earth visualization software. It provides 3D Tiles mesh layers with an embedded Floor (DTM), in addition to the mesh texture. Loading the mesh layer, QGIS fails to render the transparency that Skyline's 3DTiles set to the floor tiles. As a result, we can see white areas where the floor penetrates the mesh's texture.
Screenshot 2023-12-12 145604

Steps to reproduce the issue

  1. Open QGIS
  2. Load Scene > URL = https://cloud.skylineglobe.com/sg/demos/b3dm/857700/tileset.json
  3. Note the white areas, which should be transparent.

Versions

QGIS 3.34.1

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

Additional context

No response

@yanivday yanivday added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Dec 12, 2023
@nyalldawson
Copy link
Collaborator

Can you share a site showing what these tiles are supposed to look like?

@nyalldawson nyalldawson added the Feedback Waiting on the submitter for answers label Dec 12, 2023
@yanivday
Copy link
Author

Hi,
I appreciate your response.
Here is a web project of the same dataset:
https://cloud.skylineglobe.com/sg/tef/te.html?project=https://cloud.skylineglobe.com/sg/tutorialvideos/projects/washu.898400
3

Otherwise, you can load the 3Dtiles to ESRI ArcGIS Online:

  1. Connect to https://www.arcgis.com/home/webscene/viewer.html
  2. Sign in with an ArcGIS account.
  3. Click the + button > ArcGIS Web Service > Enter Layer URL: https://cloud.skylineglobe.com/SG/demos/arcgis/rest/services/857700/SceneServer
  4. Click Add Layer
    2

@yanivday
Copy link
Author

You can also load it with Cesium Sandcastle:

  1. Browse to: https://sandcastle.cesium.com/
  2. Add the following JavaScript code, and click Run:

const viewer = new Cesium.Viewer("cesiumContainer", {
terrain: Cesium.Terrain.fromWorldTerrain(),
});

try {
const tileset = await Cesium.Cesium3DTileset.fromUrl('https://cloud.skylineglobe.com/sg/demos/b3dm/857700/tileset.json');
viewer.scene.primitives.add(tileset);
viewer.zoomTo(tileset);
} catch (error) {
console.log(Error loading tileset: ${error});
}

5

@yanivday
Copy link
Author

Hi,
Has this been reviewed?

Copy link

github-actions bot commented Jan 5, 2024

The QGIS project highly values your report and would love to see it addressed. However, this issue has been left in feedback mode for the last 14 days and is being automatically marked as "stale".
If you would like to continue with this issue, please provide any missing information or answer any open questions. If you could resolve the issue yourself meanwhile, please leave a note for future readers with the same problem and close the issue.
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this issue.
If there is no further activity on this issue, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 5, 2024
@yanivday
Copy link
Author

yanivday commented Jan 8, 2024

Hi @nyalldawson, Were you able to look at it?

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 8, 2024
@nyalldawson nyalldawson removed the Feedback Waiting on the submitter for answers label Jan 8, 2024
@Skyline4Airwise
Copy link

Hi @nyalldawson , how can we promote this? Do you need any other information we can provide?

@P-SLISSE
Copy link

P-SLISSE commented Feb 7, 2024

Hello,
I've had the same issue with 3DTiles produced with Skyline software.
In the 3DTiles, there is some meshes with transparency value 0.0; this ones are displayed by QGis as it doesn't use the transparency of the material

            "materials":[

{
"alphaMode":"BLEND",
"name":"m0",
"pbrMetallicRoughness":
{
"baseColorFactor":[0.80000001192092896,0.80000001192092896,0.80000001192092896,0.0],
"metallicFactor":0,
"roughnessFactor":1
}
}]

I agree it would be great if QGis can use the transparency.

Other solutions :
*) There is an option when Skyline exported the 3DTiles files : you can say not to export embedded floor. In fact, that embedded floor is just unuseful in 3DTiles.

*) With CesiumGS/3d-tiles-tool you can identify the b3dm files who doesnt have textures but only materials -> this ones are the embedded floor files
Use b3dmToGltf so you can see the b3dm files which don't have an associated texture
When identified, I remove the b3dm files from the data and the problem is solved

I think the solution can be on both sides :
*) On short terms, don't produce 3DTiles containing embedded floor
Other softwares like Bentley Context Capture or Metashape don't integrate embedded floor so you don't encouter this issue
*) On middle terms, il would be great that QGis display meshes according to transparency value

I hope this will help

@saberraz
Copy link
Contributor

saberraz commented Feb 7, 2024

I am not sure if this is a bug or an unsupported feature (see https://www.lutraconsulting.co.uk/blog/2023/11/16/3d-tiles-in-QGIS/)

You can always directly contact Nyall or Lutra to address the issue.

nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Feb 12, 2024
Don't render these in 2d or 3d views

Fixes qgis#55579
nyalldawson added a commit that referenced this issue Feb 12, 2024
Don't render these in 2d or 3d views

Fixes #55579
@yanivday
Copy link
Author

Hi @nyalldawson and the team,
Thanks for your effort in implementing this! Greatly appreciated.
Is there a beta or a nightly version we can test (3.360.0)?

nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Feb 13, 2024
Don't render these in 2d or 3d views

Fixes qgis#55579

(cherry picked from commit 26f467c)
nyalldawson added a commit that referenced this issue Feb 14, 2024
Don't render these in 2d or 3d views

Fixes #55579

(cherry picked from commit 26f467c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants