-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug #9360-revival: fix whole layer not rendered (when simplify geometry activated) #1087
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2e81934
#9360R: fix bad ogr simplification
ahuarte47 b7ee396
#9360R: remove ogr_geometry.h
ahuarte47 a2b8efa
#9360R: mix CPP/C code - experimental
ahuarte47 6c14b50
#9360R: enable ogr simplification on provider side only cpp
ahuarte47 0c99423
#9360R: disable ogr simplification while OGR_G_SetPoints does not exist
ahuarte47 f79dfa1
#9360R: enable ogr simplification for GDAL-OGR >= 1.11
ahuarte47 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jef-n, I released an experimental commit, to show the problem: this 'OGR_G_SetPoint' is a terrible bottleneck because of it does a realloc of one point each new point.
The only solution that I see is disable the simplification on ogr provider side when "__cplusplus" is not enabled, I can do it because of the provider capabalities indicates if it can simplify.
What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using GEOS.... there is other option:
GEOSCoordSequence* seq = GEOSCoordSeq_create(unsigned int size, unsigned int dims);
...
GEOSGeometry * g = GEOSGeom_createLinearRing(GEOSCoordSequence* s);
char * wkb = GEOSGeomToWKT(const GEOSGeometry* g);
Do you agree ?
NOTE:
OGR provider has not references to GEOS, it is the above option better ? (Disable ogr simplification ifndef "__cplusplus" )