crs - make sure proj4 strings are trimmed #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omProj4() trim the input proj4 string
…d QgsCoordinateReferenceSystem::createFromUserInput()
|
Hi Etienne Looks great and good stuff for including a unit test. Could you add the new user wkt method to the python bindings too? Regards Tim |
|
yes I will, and also I will add another test for a plain GEOGCS node, that was not working yesterday, I'll investigate that and include it in my next pull request. thanks |
|
Tim - please see my comments in bug #5598 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to yesterday's pull request #142 and bug #5598 , following Giuseppe's suggestion to investigate leading spaces in proj4 strings.
It makes sure proj4 strings have no leading white space, and also adds a new test to make sure that CRS definitions from ESRI .prj files have towgs84 parameters inside qgis.
I have added the convenience function QgsCoordinateReferenceSystem::createFromUserInput() so we can open an ESRI definition (as well as others) using OGRSpatialReference::SetFromUserInput().
This pull request is not strictly necessary for 1.8 (especially since it adds a function to the api.