Advanced digitizing tools (aka CAD tools) #1624
Conversation
3nids
force-pushed
the
cadtool_single
branch
7 times, most recently
from
22df49c
to
0719074
Compare
3nids
force-pushed
the
cadtool_single
branch
3 times, most recently
from
72806ce
to
6eb0e21
Compare
|
Thanks to intensive testing from @olivierdalang |
|
Nice. Going to build again and do some more testing. On Thu Oct 30 2014 at 12:35:29 AM Denis Rouzaud notifications@github.com
|
3nids
force-pushed
the
cadtool_single
branch
4 times, most recently
from
75038cd
to
f233001
Compare
3nids
force-pushed
the
cadtool_single
branch
2 times, most recently
from
44e0c41
to
9a4f29d
Compare
this integrates advanced digitizing tools aka CAD tools in QGIS application and basically a port of CADinput plugin * new class QgsMapToolAdvancedDigitizing shall be subsclassed if adv. digit. tools could be used in a map tool * QgsAdvancedDigitizingDockWidget handles the interaction with the user and also perform the constraints (filters events) * QgsAdvancedDigitizingCanvasItem paints construction lines on the canvas
| } | ||
| else | ||
| { | ||
| // try to evalute expression |
There was a problem hiding this comment.
@3nids might be worthwhile changing this part to use the new QgsExpression::evaluateToDouble method. You can see how it's used in QgsDoubleSpinBox::valueFromText. It's got full test coverage so should be safer to use than this duplicate code.
There was a problem hiding this comment.
@3nids it's probably worth mentioning that I plan on adding a QgsLineEdit widget which has built in support for evaluating expressions too.
There was a problem hiding this comment.
Thanks for the feedback.
Just a remark, I would like to have another method as evaluateToDouble which has const QString& text, bool &ok as parameters since I only have the text from the line edit as input (so no fallback value).
What do you think?
Advanced digitizing tools (aka CAD tools)
This integrates CAD tools in QGIS application.
This is roughly the port of CADinput plugin to core, with some fixes and improvements.
A QEP has been issued: qgis/QGIS-Enhancement-Proposals#8