Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for issues #5753 and #5754 #165

Merged
merged 2 commits into from
Jun 10, 2012
Merged

Fixes for issues #5753 and #5754 #165

merged 2 commits into from
Jun 10, 2012

Commits on Jun 10, 2012

  1. Simple fix for qgis#5754 (Mac OS-specific). Better fix would be to ma… 

    …ke a method that set all QAction additions to base menus (submenus ok) to QAction::NoRole. This would keep any new action from hijacking the Mac app's About or Preferences… menus.

See: http://doc.qt.nokia.com/4.7.1/qmenubar.html#qmenubar-on-mac-os-x
    @dakcarto
    dakcarto committed Jun 10, 2012
    Configuration menu
    Copy the full SHA
    f01c6ad View commit details
    Browse the repository at this point in the history

  2. Fix for qgis#5753 

    Does not address third-party plugins that add their own menus. They should use (here for Python):

menu_bar = self.iface.mainWindow().menuBar()
menu_bar.insertMenu( self.iface.firstRightStandardMenu().menuAction(), self.my_plugins_menu )

Ideally, a new QgisInterface public slot pair of addMenuToMenuBar(QMenu)/removeMenuFromMenuBar(QMenu) should be added, to help plugin developers put their menus in the correct place.

Deletion in GdalTools.py is redundant add-to-menu code. It moved the Raster menu to -1 on the menubar (between Window and Help on Mac).
    @dakcarto
    dakcarto committed Jun 10, 2012
    Configuration menu
    Copy the full SHA
    7f1a4e2 View commit details
    Browse the repository at this point in the history