Refactor displayField to displayExpression/mapTipTemplate #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kuhn
force-pushed
the
featuretitlemaptip
branch
from
efe69db
to
bc80ce0
Compare
|
good job! It might be better to move the feature title definition to the field tab? Although, the field tab really need room. Maybe, on the general tab then? otherwise +1 for merging! |
|
@m-kuhn any plans to resurrect this? |
m-kuhn
force-pushed
the
featuretitlemaptip
branch
from
bc80ce0
to
45fd54d
Compare
|
If it's ever going to happen then during this api break. Take 2... Changes compared to before:
|
m-kuhn
changed the title
Previously there was the expressionField (a field name or an expression) mainly used for the feature list in the form view of the dual view. On the other hand there was the displayField which could contain either a simple field name or a complex HTML structure with embedded expressions. And to know what it was you could compare it's content with the field names, if a field name matched, you used it as a displayField (original purpose) and if not... well, you could deal with HTML if you had a use for it. The main problem is that there are two different usages for this kind of thing * plain text identifier (field or expression) * pretty, rich text feature info This commit cleans up with this. You want rich text and a lot of info: go for mapTipTemplate. You want a plain text string to identify features: go for the displayExpression.
m-kuhn
force-pushed
the
featuretitlemaptip
branch
from
45fd54d
to
893bd52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was the expressionField (a field name or an expression) mainly
used for the feature list in the form view of the dual view.
On the other hand there was the displayField which could contain either a
simple field name or a complex HTML structure with embedded expressions. And to
know what it was you could compare it's content with the field names, if a
field name matched, you used it as a displayField (original purpose) and if
not... well, you could deal with HTML if you had a use for it.
The main problem is that there are two different usages for this kind of thing
This commit cleans up with this. You want rich text and a lot of info: go for
the mapTip. You want a plain text string to identify features: go for the
featureTitle.