New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement implicit sharing for QgsField #2019
Conversation
@@ -86,9 +88,9 @@ public: | |||
|
|||
/** | |||
Set the field type. | |||
@param typ Field type | |||
@param type Field type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typeName
If you want to experiment with implicit sharing, go for |
@m-kuhn agreed, but I wanted to start with something straightforward as a trial... |
@nyalldawson fair enough. |
@m-kuhn I think QSharedData/QSharedDataPointer takes care of that automatically. I'm struggling to find definite answers either way... |
I think it may be good to define PS: Please don't expect that I completely have understood the article in every detail... |
@m-kuhn how's this? It probably needs some extra cmake changes to keep the _p.h header private too... |
Looks good to me. Maybe the private header could somehow be removed from install/devel-packages. But I don't think it hurts apart from inflating them. |
manually merged |
Great stuff :-) |
… caller Fix qgis#2019 - DBManager fails to display error messages with virtual layers
Implements implicit sharing for QgsField. I'm seeking comments on whether this is a correct implementation of Qt's implicit sharing classes, and if so, will continue to switch additional classes to be implicitly shared.