[db-manager] Store exception text in the task and pass it over to the… #8283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… caller Fix qgis#2019 - DBManager fails to display error messages with virtual layers
|
Nice :) I was thinking of something similar. |
|
I wonder if other providers have the same issue ... we might come up with a more general solution for 3.6 |
|
I confirm the patch works here nicely! |
|
Maybe better |
nyalldawson
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… caller
Fix #2019 - DBManager fails to display error messages with virtual layers
@nyalldawson not sure if this is the right approach, but it works