[OSM] improve handling of closed ways #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This actually fixes an issue I discussed with @wonder-sk a long time ago that never ended up filed on the hub.qgis.org. |
wonder-sk
added a commit
that referenced
this pull request
Jun 2, 2015
[OSM] improve handling of closed ways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of area-defining tags when considering whether a closed way tagged with highway or barrier is an area, or only a line. The proposed handling better reflects OSM's behavior (see http://wiki.openstreetmap.org/wiki/Key:area).
The commit also allows for a same closed way tagged with highway or barrier to be exported both as a polygon - when area-defining tags are present - as well as lines. For e.g., if a closed way is flagged as an amenity=embassy, and barrier=wall, the closed way will export both to a polygon, and a line.
Prior to this PR, the area intent (defined through tags) would simply be lost, and only a line would be exported.