Add node editor widget and change node tool to click-click mode #2217
Conversation
|
On Wed, Jul 22, 2015 at 7:35 PM, mhugent notifications@github.com wrote:
What is click-click mode? |
|
@NathanW2: select vertex with one click and place it with a second click (rather than a drag). This allows to use the advanced digitize toolbar also for the node tool. |
|
Ok cool. Yes this is good idea. More CAD like. I haven't tested the code On Wed, Jul 22, 2015 at 7:38 PM, mhugent notifications@github.com wrote:
|
| if ( !m.isValid() ) | ||
| if ( mMoveRubberBands.empty() ) | ||
| { | ||
| QgsGeometryRubberBand* rb = new QgsGeometryRubberBand( mCanvas, mSelectedFeature->geometry()->type() ); |
There was a problem hiding this comment.
@mhugent this should be constGeometry() to avoid the detach. Also in 144. 424, 431
There was a problem hiding this comment.
QgsSelectedFeature (in contrast to QgsFeature) does not have a constGeometry(). But yes, for 424,431 and the two other occurences below, it is better to use constGeometry().
to avoid the detach
afaik detach is only called when a non-const operation is really called on that object.
There was a problem hiding this comment.
@mhugent - ahh, i missed that QgsSelectedFeature reference, sorry. The situation with geometry/constGeometry is a little messy, however. QgsFeature::geometry() will ALWAYS trigger a detach, and constGeometry() will never detach. We had to go that way to maintain API - since QgsFeature::geometry() returns a non const pointer, it can be used to modify the feature's geometry and we have no way of knowing if this will be done so have to detach. In 3.0 this will be cleaned up so that geometry() will always return a QgsGeometry object (not reference of pointer, since QgsGeometry is now implictly shared), and geometry modification will be done via QgsFeature::setGeometry. But in the meantime we should avoid all use of QgsFeature::geometry() (it's effectively deprecated) and rely on constGeometry/setGeometry instead. There's some notes to this effect in the docs for QgsFeature.
|
@mhugent Also note that all the new classes/methods need doxygen documentation - that's what's tripped up the PyQgsDocCoverage test and caused Travis to reject this PR |
| @@ -63,10 +69,10 @@ bool QgsVectorLayerEditUtils::moveVertex( double x, double y, QgsFeatureId atFea | |||
| if ( !L->getFeatures( QgsFeatureRequest().setFilterFid( atFeatureId ).setSubsetOfAttributes( QgsAttributeList() ) ).nextFeature( f ) || !f.constGeometry() ) | |||
| return false; // geometry not found | |||
|
|
|||
| geometry = *f.constGeometry(); | |||
| geometry = *f.geometry(); | |||
There was a problem hiding this comment.
@mhugent looks like this one slipped through :)
|
it seems the detection of the node is not working properly. |
Add node editor widget and change node tool to click-click mode
No description provided.