[DB_Manager] allows to specify multiple columns as the primary for a query to PostGIS #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keyColumn to a separate function.
…span multiple columns.
…uery and when pressing the load columns button.
…en running the query or rereading the columns if the selected columns still exist.
…es, not for SpatiaLite.
|
@jef-n should this be considered a bug fix (not new feature) as it follows the merge you've done few days ago? Or should we wait until the end of feature freeze? |
brushtyler
added a commit
that referenced
this pull request
Oct 22, 2015
[DB_Manager] allows to specify multiple columns as the primary for a query to PostGIS (follow a4124da)
|
Merged, so to be consistent with provider behaviour. Thanks. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a4124da it is possible to specify a primary key spanning multiple columns for PostGIS layers based on a query.
This PR modifies the DB_Manager to support this new feature for queries to PostGIS. When building a query to SpatiaLite still only one column can be selected.
This PR also fixes the odd behavior of setting the selected columns back to the default when rerunning the query or reloading the fields, even if the selected columns still exist.