Apply filters to feature request for categorized renderer #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes rendering much faster when only certain categories are checked, as only the matching records for the displayed features are fetched from the provider.
|
@m-kuhn I'm pretty confident this is safe to merge (it's been heavily tested), but do you mind having a quick look as I gather you implemented the renderer filter support? |
|
|
||
| if ( !cat.renderState() ) | ||
| { | ||
| allActive = false; |
There was a problem hiding this comment.
Good catch, thanks!
|
LGTM |
|
Merged in 9eee121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes rendering for the categorized renderer MUCH faster when only certain categories are checked, as only the matching records for the displayed features are fetched from the provider. The current behaviour is that ALL features are fetched, and then only those with a matching value are rendered.