Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new mime icons #2585

Closed
wants to merge 76 commits into from
Closed

Added new mime icons #2585

wants to merge 76 commits into from

Conversation

SrNetoChan
Copy link
Member

Added new mime icons for qgs, qml, qlr, qpt and others files extentions in SVG.

Not sure where else I need to tweak to make Operative Systems to assume the Icons for that file formats. Help is needed.

@Scimmia22
Copy link
Contributor

The name "other_mime_icon.svg" is pretty generic. It would probably be better to name it more distinctively instead of having each OS integrator decide what to rename it to.

Edit, the more I think about it, the more I think people are going to rename it anyway, so it may not matter.

@SrNetoChan
Copy link
Member Author

@Scimmia22 Currently mime_icon.PNG is used for all file formats related to QGIS. That Includes QGIS's qgs, qpt, qlr, qml and others like all formats of shapefile. My ideia for other_mime_icon.svg would be to replace those "others" non qgis files. The best name would in fact be mime_icon.svg, but in that case I should update or even delete the mime_icon.png file. What do you think?

Also, I'm not sure of all file formats currently using that Icon, otherwise we might think of creating similar, yet distinct icons for each. Say shapefile, spatialite, tiff...

@Scimmia22
Copy link
Contributor

SrNetoChan, there is no mime_icon.PNG. The current icon is called qgis-mime-icon.png.

My point is that mime_icon.svg and mime_icon.png are not good names for OSs that have all icons in the same dir.

@SrNetoChan
Copy link
Member Author

@Scimmia22 Please suggest better names then. I will gladly change it.

@kyngchaos
Copy link
Contributor

Mac icons need to be rasterized at different sizes and merged into a .icns format. There are tools on OS X to create the icns file. They also need to be registered in the OS X app Info.plist. I see that that OS X has had icons for many common files for a long time, including the qgs document and qml, but not qlr or qpt.

@SrNetoChan
Copy link
Member Author

@kyngchaos thank you. I will take care of that.

@SrNetoChan
Copy link
Member Author

@Scimmia22 I think I have now understood what you meant. I will take change that. Thanks for the input.

@m-kuhn m-kuhn added this to the 2.14 milestone Dec 21, 2015
SebDieBln and others added 18 commits January 4, 2016 00:06
Was always returning a point not on the surface! (0,0). Use the
GEOS method instead.
...smallest diff for a new feature ever ;)
Also properly closes the iterator when a fallback orderby is used
This allows defining the order in which features are processed by
renderers.
The settings were allocated in the stack
causing a segfault when accessed from the slot

Fixes qgis#14021
SebDieBln and others added 28 commits January 4, 2016 00:06
This avoids corrupted project files when crashing during the preparation of the XML data to write to the project file, e.g. due to a faulty plugin.
If an error occurs while loading the project file, prompt the user to load the backup file instead, if it exists.
When embedding layers, reread the external project file if its lastModified timestamp changed.
Since it's just a int64, it's faster to pass by value
The term "Not supported" is not appended to the label when it is already present.
The term is removed when no longer applicable.
(an attempt to debug test failures in debian)
- remove use of namespace blocks (avoids unnecessary indentation)
- cleanup includes
- remove old std::cout debugging blocks
- move some documentation from cpp to headers
@SrNetoChan SrNetoChan closed this Jan 4, 2016
@SrNetoChan
Copy link
Member Author

I have messed up with git... not good. So I have closed this to make a proper pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet