Print Composer shape combo box not refecting current shape

[qgib]

Author Name: Donkagen2 - (Donkagen2 -)
Original Redmine Issue: 4035

---

Draw a new shape. The new shape is an ellipse and shows on the Item tab Shape combo box as Ellipse... as expected.
Click on the combo and select Rectangle - the shape changes to a rectangle but the combo still says Ellipse.
Select rectangle from the combo again and the combo then shows Rectangle.

It seems that the combo saves the current shape name rather than the new picked name.

---

• shapeSelection.diff (Anna Kratochvilova)

[qgib]

Author Name: Nathan Woodrow (@NathanW2)

---

I can't seem to replicate this. Which version are you running.

[qgib]

Author Name: Anna Kratochvilova (Anna Kratochvilova)

---

I can reproduce it in 1.7.1 on Ubuntu. The signal @currentIndexChanged@ is connected to 2 slots. I tried to remove connection to @setGuiElementValues@. Instead, I added another connection between item and widget (similar to other composer items), although I'm not sure if it is necessary. See the patch.

---

• 3539 was configured as shapeSelection.diff

---

• shapeSelection.diff (Anna Kratochvilova)

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

Some can review and eventually commit this patch? thanks.

---

• pull_request_patch_supplied was configured as 1

[qgib]

Author Name: Marco Hugentobler (@mhugent)

---

Agreed, it's good to connect itemChanged() signal, because the widget stays in sync when using undo/redo functions. In future it will be good to emit more itemChanged() signals in the composer items. Like that, the widget stays in sync also if an item change comes from a python plugin.

---

• status_id was changed from Open to Resolved

[qgib]

Author Name: Alexander Bruy (@alexbruy)

---

Seems fixed in 4b86c71

---

• resolution was changed from to fixed
• status_id was changed from Resolved to Closed