[graduated symbology] increase precision of float values when saving to dom #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanW2
added a commit
that referenced
this pull request
Dec 26, 2015
[graduated symbology] increase precision of float values when saving to dom
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving the range lower and upper values (double) to the DOM, the number is truncated to 6 decimal values, which is a problem when your range is composed of double values with a precision above 6 decimals.
This PR simply increase the precision to 15.
This fixes a pretty serious issue whereas re-opening a project with layers rendered via graduated symbology would not look the same (because the classes values were truncated), leading to a different visual look, and often the highest feature(s) would not be rendered as the values would be above the truncated value saved in the dom. That issue was raised in http://hub.qgis.org/issues/14036 (with wrong initial assumptions, subsequently rectified 😄).