Always translate Processing debug messages tab title #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,6 +31,7 @@ | |||
| import datetime | |||
| from processing.tools.system import userFolder | |||
| from processing.core.ProcessingConfig import ProcessingConfig | |||
| from processing.core import Processing | |||
There was a problem hiding this comment.
This introduces circular dependency. ProcessingLog imports Processing and in same time Processing imports ProcessingLog. IMHO it is better to create method in the ProcessingLog class for i18n support, like in we already have in ProcessingConfig
def tr(self, string, context=''):
if context == '':
context = 'ProcessingLog'
return QCoreApplication.translate(context, string)
There was a problem hiding this comment.
Thanks for the review Alex
alexbruy
added a commit
that referenced
this pull request
Feb 18, 2016
[processing] always translate debug messages tab title (fix #14287)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14287 (Redmine)
@volaya does it make sense to you to translate the log tab title? Other tab titles there are translated as well.