[Bugfix] keep feature rendering order settings when changing renderers (fixes #14347) #2831
Conversation
| @@ -222,7 +222,6 @@ void QgsRendererV2PropertiesDialog::rendererChanged() | |||
| { | |||
| if ( mMapCanvas ) | |||
| mActiveWidget->setMapCanvas( mMapCanvas ); | |||
| changeOrderBy( mActiveWidget->renderer()->orderBy(), mActiveWidget->renderer()->orderByEnabled() ); | |||
There was a problem hiding this comment.
Just keep the settings in the dialog unchanged, they are what we want. The settings within the renderer() are only updated when applying the changes to the layer.
There was a problem hiding this comment.
If one creates a new 2.5D renderer and then switches to the standard one, is the order by imposed by the 2.5D renderer still in place?
There was a problem hiding this comment.
Wrong question 😄 The right question is:
If one switches to the 2.5D renderer, does it overwrite the order settings made by the user with the ones needed for the 2.5D renderer?
And as you can guess, the answer is: No.
So this PR definitly needs changes.
There was a problem hiding this comment.
The way in which this has been implemented is by no means perfect. Silently overwriting different settings (layer variables, order by, style...) by just switching the combobox is not the best UX ever. So if you have a good suggestion how this could be improved, feel free to tell :)
m-kuhn
added
the
Requires Changes!
|
Closing this - there's significant work remaining as this issue will need to be tackled in a different way. |
When changing the renderer (e.g. from single symbol to graduated), the settings for the feature rendering order are reset to the settings of the layer. Any changes to these settings not yet applied to the layer are lost.
This PR fixes that.