Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just keep the settings in the dialog unchanged, they are what we want. The settings within the
renderer()
are only updated when applying the changes to the layer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If one creates a new 2.5D renderer and then switches to the standard one, is the order by imposed by the 2.5D renderer still in place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong question 😄 The right question is:
If one switches to the 2.5D renderer, does it overwrite the order settings made by the user with the ones needed for the 2.5D renderer?
And as you can guess, the answer is: No.
So this PR definitly needs changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way in which this has been implemented is by no means perfect. Silently overwriting different settings (layer variables, order by, style...) by just switching the combobox is not the best UX ever. So if you have a good suggestion how this could be improved, feel free to tell :)