Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] keep feature rendering order settings when changing renderers (fixes #14347) #2831

Closed
wants to merge 1 commit into from
Closed

[Bugfix] keep feature rendering order settings when changing renderers (fixes #14347) #2831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/gui/symbology-ng/qgsrendererv2propertiesdialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ void QgsRendererV2PropertiesDialog::rendererChanged()
{
if ( mMapCanvas )
mActiveWidget->setMapCanvas( mMapCanvas );
changeOrderBy( mActiveWidget->renderer()->orderBy(), mActiveWidget->renderer()->orderByEnabled() );
connect( mActiveWidget, SIGNAL( layerVariablesChanged() ), this, SIGNAL( layerVariablesChanged() ) );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just keep the settings in the dialog unchanged, they are what we want. The settings within the renderer() are only updated when applying the changes to the layer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If one creates a new 2.5D renderer and then switches to the standard one, is the order by imposed by the 2.5D renderer still in place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong question 😄 The right question is:
If one switches to the 2.5D renderer, does it overwrite the order settings made by the user with the ones needed for the 2.5D renderer?
And as you can guess, the answer is: No.

So this PR definitly needs changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way in which this has been implemented is by no means perfect. Silently overwriting different settings (layer variables, order by, style...) by just switching the combobox is not the best UX ever. So if you have a good suggestion how this could be improved, feel free to tell :)

}
}
Expand Down