[Bugfix] More comprehensive interface update in symbology (fixes #14224)

[dgoedkoop]

This fixes two bugs this bug:

1. Bug on-line labeling doesn't work anymore #14224: The labeling widget in the layer properties dialog is not updated (except for the labeling type combobox) when loading a style, so that the labeling settings from the loaded style file are only applied if you press 'cancel' rather than 'ok' in the layer properties dialog.
   2. When you load a style, it is applied immediately, without the need to press 'ok' or 'apply'. However, the interface is not updated reflected to show this. Thus, currently, if you load a style and then press 'cancel', the loaded style is applied to the layer, but the interface is updated (and the project is marked dirty) only after making another change (such as panning the map). Not necessary anymore because of 25a162c .

[dgoedkoop]

Anyone? I won't insist that my code is good, but I'd really like to have this fixed because my employer doesn't want to upgrade to 2.14 as long as this regression is present.

[NathanW2]

Sorry for the delay. We will have a look into it. So these are regressions
in 2.14?

On Fri, Apr 1, 2016 at 10:38 PM, Daan Goedkoop notifications@github.com
wrote:

Anyone? I won't insist that my code is good, but I'd really like to have
this fixed because my employer doesn't want to upgrade to 2.14 as long as
this regression is present.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#2929 (comment)

[dgoedkoop]

@NathanW2 Compared to the previous LTR version 2.8... The problem seems to have been introduced with the rule-based labelling option. PR #2542 tried to fix it, but only resolved the issue partly.

[NathanW2]

OK We will follow it up soon.

On Fri, Apr 1, 2016 at 10:54 PM, Daan Goedkoop notifications@github.com
wrote:

@NathanW2 https://github.com/NathanW2 Compared to the previous LTR
version 2.8... The problem seems to have been introduced with the
rule-based labelling option. PR #2542
#2542 tried to fix it, but only
resolved the issue partly.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2929 (comment)

[dgoedkoop]

Ok! Many thanks in advance!

[dgoedkoop]

Do I need to do anything now that the travis check failed due to a time-out?

[dgoedkoop]

Ah, it looks like Nathan's work on the styling dock has fixed this already. :)

[DelazJ]

@NathanW2 's work is a new feature so won't be backported in 2.14. This bug still needs a fix for those that will keep using that release.

[dgoedkoop]

@DelazJ That's true. Silly that I forgot about it, because we use the LTR releases ourselves too. I've made a new PR #3054 based against the 2.14 branch.