[Bugfix] Update labeling settings after loading style from file (fixes #14224) #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgoedkoop
changed the title
|
@NathanW2 does this look ok to you? |
|
Looks ok to me. |
|
Ok then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug #14224: The labeling widget in the layer properties dialog is not updated (except for the labeling type combobox) when loading a style, so that the labeling settings from the loaded style file are only applied if you press 'cancel' rather than 'ok' in the layer properties dialog.
This PR is the same as #2929 but based against the 2.14 branch. In master it has been rendered superfluous by the new layer styling dock, but this bug should still be fixed in the LTR release.