Pluginlegend customize

[tqhien]

Hello,

I created a new branch to allow customization of plgins in the legend dock.
The plugin should call as in your test plugin (I changed the id to make it more simple):
self.iface.legendInterface().addLegendLayerAction(self.action_add_sel_tiles, "Tile Index", "addSelTiles", QgsMapLayer.VectorLayer )

in order to be enabled.

In customization dialog, it will appears under Docks/Legends/Plugins//

On a right-click on a layer, a submenu named will regroup the actions.

Can you test it and give me a feedback ?

Hien TRAN-QUANG

[etiennesky]

I am going to close this pull request, for a few reasons

1- you removed the work I had done in layerlegend_customize
2- indentation is not right - please run 'scripts/prepare-commit.sh' before comittting, it ensures correct indentation

now may I ask why you discregarded a number of my commits, instead of adding commits after? This results in a waste of time for everyone.

thanks
Etienne

[etiennesky]

Hien

can you please add any changes (after my commits) to the correct branch - layerlegend_customize

thanks

[tqhien]

Hello,

Sorry I think I have messed up something when I fetch your commits and
couldn't build the project anymore. I tried to reset back but somehow went
probably too far.

I'm going to restart from your commits and add commits after.

Just a few questions :

• in addLegendLayerAction, your stringid is prefixed with the plugin name.
  Is that a requisite ? There's already the Qstring menu just before.

Just checking your code, it seems we worked on two parallel branches : for
me the plugin integration was a new feature, so I created a new branch to
test things out while you were still on the layerlegend_customize.

Can you tell me which part I can contribute to, so I don't mess things up
again and we don't do twice the job ?

Thanks

Hien.

2012/10/15 Etienne Tourigny notifications@github.com

I am going to close this pull request, for a few reasons

1- you removed the work I had done in layerlegend_customize
2- indentation is not right - please run 'scripts/prepare-commit.sh'
before comittting, it ensures correct indentation

now may I ask why you discregarded a number of my commits, instead of
adding commits after? This results in a waste of time for everyone.

thanks
Etienne

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/294#issuecomment-9451929.

[etiennesky]

In addLegendLayerAction it is preffered to add the plugin name, just to make sure there are no clashes, but there is no enforcement. The menu name is optional, and can be different from the id which should be unique. For example, menu name can be translated with tr(), but id should not, it's internal to the plugin design.

I was always working on my layerlegend_customize branch, after pulling from your branch. No need to have 2 branches because these are related features, the plugin customization requires your legend customization. Please add any fixes/enhancements there. What is missing is the customization part (selecting which ones are visible or not).

If you prefer I will add that and you can review, but I will not have time before tomorrow.

thanks

[tqhien]

Ok, I understand now.

I don't know yet if I'll get time to modify the customization part before
the end of the week.
And I 'm looking for a way not to restart all the application when we
customize the interface (that is already ok for the legend dock as it
searches the registry/settings file whenever we right-click).

Thanks.

Hien.

2012/10/16 Etienne Tourigny notifications@github.com

In addLegendLayerAction it is preffered to add the plugin name, just to
make sure there are no clashes, but there is no enforcement. The menu name
is optional, and can be different from the id which should be unique. For
example, menu name can be translated with tr(), but id should not, it's
internal to the plugin design.

I was always working on my layerlegend_customize branch, after pulling from
your branch. No need to have 2 branches because these are related features,
the plugin customization requires your legend customization. Please add any
fixes/enhancements there. What is missing is the customization part
(selecting which ones are visible or not).

If you prefer I will add that and you can review, but I will not have time
before tomorrow.

thanks

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/294#issuecomment-9487579.