[API/feature?] Cache feature ids for each symbol in the QgsVectorLayer #31061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a proposal to cache the feature ids in the vector layer, similar to what is currently done with the counts.
The method to the the Fids is an extra in case someone would need it eventually.
This replaces the PR #30950 where it was proposed to use the counter directly but was discarded due to thread safety issues as highlighted by @nyalldawson
The need to have the fids comes from the symbology expression PRs where I need to provide the fids of the features to the expression and I need to store and access this list of fids from somewhere when the aggregate function is evaluated.
Any feedback is appreciated
Checklist
fixes #11111
in the commit message next to the description[FEATURE]
in the commit message[needs-docs]
in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.sh
script before each commit