Expression based QgsProperty optimisations #31159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retry preparing it for every feature rendered This can cause a huge slowdown on projects where a layer has a data defined property with an invalid expression (e.g. due to a field which has been renamed or dropped). Sponsored by QGIS grant, identified by Hotspot
based properties Sponsored by QGIS grant, identified by Hotspot
…ed expression preparation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optimisations to QgsProperty which greatly speed up data defined symbology rendering in some circumstances.
(I don't plan on backporting this ones -- there's a small chance (I guess around 0.5%) it may cause a regression, so I'd rather it just waits it out in master only for now)
Thanks to QGIS grant, sponsored by Hotspot.