-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topological editing: fix vertex tool (Z support) #31163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
reviewed
Aug 8, 2019
lbartoletti
force-pushed
the
topological_nodetool
branch
from
August 8, 2019 12:13
427e27e
to
cf6cb6b
Compare
pblottiere
reviewed
Aug 8, 2019
pblottiere
reviewed
Aug 8, 2019
This reverts commit cf6cb6b.
9 tasks
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport release-3_8
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick e4191a63e6978e70dd725d10758183f8b8594f15 a3c2cf59ca40fea02e4bc9f16f06f8d12ccf9401 cf6cb6bd758a5e3a1f01e7e565bd4ac84d111155 f113898b8c24b95c7952042b37ed72b604c9ab3b b15361ae17bb80382b91d9a096c700c8b9a885fa 99d8b6bac61ecd066d767c859f59b98e5cd58f99
# Create a new branch with these backported commits.
git checkout -b backport-31163-to-release-3_8
# Push it to GitHub.
git push --set-upstream origin backport-31163-to-release-3_8
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix topological point and add z support.
The Z snapped on a segment is always the default Z. I will correct this behavior in a dedicated PR.
Before
After
Sponsored by QWAT group @ponceta
Checklist
fixes #11111
in the commit message next to the description[FEATURE]
in the commit message[needs-docs]
in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.sh
script before each commitBackport