Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate add topological points xy #31171

Merged
merged 9 commits into from Oct 3, 2019
Merged

Deprecate add topological points xy #31171

merged 9 commits into from Oct 3, 2019

Conversation

lbartoletti
Copy link
Member

Description

Follow up #31163 (comment)

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

Backport

  • I request the backport of the changes to the Latest Release
  • I request the backport of the changes to the Long Term Release

@lbartoletti lbartoletti mentioned this pull request Aug 8, 2019
Merged
9 tasks
@lbartoletti lbartoletti force-pushed the deprecate_addTopologicalPointsXY branch 2 times, most recently from 6d2ecb4 to 8f869b2 Compare August 9, 2019 07:35
@lbartoletti lbartoletti force-pushed the deprecate_addTopologicalPointsXY branch 5 times, most recently from c73a7a5 to 5140f5a Compare August 16, 2019 08:21
@lbartoletti lbartoletti changed the title [WIP] Deprecate add topological points xy Deprecate add topological points xy Aug 16, 2019
@lbartoletti lbartoletti added Squash! Remember to squash this PR, instead of merging or rebasing API API improvement only, no visible user interface changes and removed Squash! Remember to squash this PR, instead of merging or rebasing labels Aug 16, 2019
@lbartoletti lbartoletti force-pushed the deprecate_addTopologicalPointsXY branch from 5140f5a to dfe0fa9 Compare August 16, 2019 11:02
@lbartoletti lbartoletti reopened this Aug 16, 2019
@stale
Copy link

stale bot commented Aug 30, 2019

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 30, 2019
@lbartoletti
Copy link
Member Author

Hey stale bot, can you merge it, please? :)

@stale stale bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 1, 2019
@nyalldawson nyalldawson added this to the 3.10.0 milestone Sep 8, 2019
@lbartoletti lbartoletti force-pushed the deprecate_addTopologicalPointsXY branch from 0e0c12b to 7171728 Compare September 10, 2019 12:57
@lbartoletti lbartoletti force-pushed the deprecate_addTopologicalPointsXY branch from 7171728 to 3e9f57a Compare September 12, 2019 04:40
@lbartoletti
Copy link
Member Author

Good for you nyall?

nyalldawson
nyalldawson reviewed Sep 25, 2019
View reviewed changes
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there! 😄

python/core/auto_generated/qgsvectorlayereditutils.sip.in Show resolved Hide resolved
src/app/qgsmaptoolfillring.cpp Outdated Show resolved Hide resolved
src/core/geometry/qgsgeometry.h Outdated Show resolved Hide resolved
src/core/qgsvectorlayer.cpp Show resolved Hide resolved
@lbartoletti lbartoletti force-pushed the deprecate_addTopologicalPointsXY branch from 28c7dd6 to 769125e Compare October 1, 2019 09:00
@nyalldawson nyalldawson merged commit 775ef66 into qgis:master Oct 3, 2019
@nyalldawson
Copy link
Collaborator

Great work -- thanks for pushing this one through!

@lbartoletti
Copy link
Member Author

And thank you for your review and advice

@lbartoletti lbartoletti deleted the deprecate_addTopologicalPointsXY branch October 3, 2019 05:47
@lbartoletti lbartoletti mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
API API improvement only, no visible user interface changes
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lbartoletti @nyalldawson