Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for finished in abstract content cache when fetching with blocking #32222

Merged

Conversation

rldhont
Copy link
Contributor

@rldhont rldhont commented Oct 12, 2019

Description

After trying to fix travis segfault with Abstract content cache: delete task later #32218
The commit uses waitForFinished with arbitrary setting maximum wait to 5 seconds.

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include Fixes #11111 at the bottom of the commit message
  • I have read the QGIS Coding Standards and this PR complies with them
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
  • I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

@rldhont rldhont added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Oct 12, 2019
@rldhont rldhont added this to the 3.10.0 milestone Oct 12, 2019
@nyalldawson
Copy link
Collaborator

ARguably a much nicer approach anyway :D

@rldhont
Copy link
Contributor Author

rldhont commented Oct 12, 2019

@nyalldawson travis is happy: no segfault and all tests passed

@rldhont rldhont merged commit 29520d6 into qgis:master Oct 13, 2019
@rldhont rldhont deleted the abstract-content-cache-task-wait-for-finished branch January 2, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants