Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract content cache: delete task later #32218

Merged
merged 1 commit into from
Oct 12, 2019
Merged

Abstract content cache: delete task later #32218

merged 1 commit into from
Oct 12, 2019

Conversation

rldhont
Copy link
Contributor

@rldhont rldhont commented Oct 12, 2019 •
edited
Loading

Description

Try to fix travis segfault by replacing the delete task calls with task->deleteLater() in QgsAbstractContentCache

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include Fixes #11111 at the bottom of the commit message
  • I have read the QGIS Coding Standards and this PR complies with them
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
  • I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

@rldhont
Abstract content cache: delete task later
b9de717 
Try to fix travis segfault by replacing the delete task calls with task->deleteLater() in QgsAbstractContentCache
@rldhont rldhont added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Oct 12, 2019
@rldhont rldhont added this to the 3.10.0 milestone Oct 12, 2019
@rldhont
Copy link
Contributor Author

rldhont commented Oct 12, 2019

Test does not segfault at the first time.

@rldhont
Copy link
Contributor Author

rldhont commented Oct 12, 2019

Second and third build without segfault

@nyalldawson nyalldawson merged commit d9ef585 into qgis:master Oct 12, 2019
@rldhont
Copy link
Contributor Author

rldhont commented Oct 12, 2019

thanks

@rldhont
Copy link
Contributor Author

rldhont commented Oct 12, 2019

it does not fix the issue.

This was referenced Oct 12, 2019
Merged
Merged
@rldhont rldhont deleted the abstract-content-cache-delete-task branch January 2, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rldhont @nyalldawson