Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE][symbology] Add density-based point count for the random marker fill #32456

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Oct 28, 2019

Description

This PR adds a density-based point count method to @nyalldawson 's brand new random marker fill.

GIF time:
Peek 2019-10-28 16-00

Edit: i should probably expand a little bit more here. The benefit of this new method is that contrary to an absolute count, the fill density will remain the same on different scale / zoom levels (as demonstrated in the GIF above).

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include Fixes #11111 at the bottom of the commit message
  • I have read the QGIS Coding Standards and this PR complies with them
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
  • I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

@nirvn nirvn added Requires Tests! Waiting on the submitter to add unit tests before eligible for merging Symbology Related to vector layer symbology or renderers labels Oct 28, 2019
@nirvn
Copy link
Contributor Author

nirvn commented Oct 28, 2019

@nyalldawson , I wasn't so sure of the newly-added function wording, feel free to suggest better alternatives if you can think of any.

I'll add tests once the code is reviewed.

src/core/symbology/qgsfillsymbollayer.cpp Outdated Show resolved Hide resolved
src/core/symbology/qgsfillsymbollayer.h Show resolved Hide resolved
src/core/symbology/qgsfillsymbollayer.h Outdated Show resolved Hide resolved
src/core/symbology/qgsfillsymbollayer.h Outdated Show resolved Hide resolved
src/core/symbology/qgsfillsymbollayer.h Show resolved Hide resolved
src/gui/symbology/qgssymbollayerwidget.cpp Outdated Show resolved Hide resolved
src/gui/symbology/qgssymbollayerwidget.cpp Outdated Show resolved Hide resolved
src/core/symbology/qgsfillsymbollayer.cpp Outdated Show resolved Hide resolved
src/core/symbology/qgssymbollayer.h Show resolved Hide resolved
@nirvn nirvn added Feature and removed Requires Tests! Waiting on the submitter to add unit tests before eligible for merging labels Oct 29, 2019
@nirvn
Copy link
Contributor Author

nirvn commented Oct 29, 2019

@nyalldawson , your comments have been addressed, and a test added.

Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there!

src/core/qgsrendercontext.cpp Outdated Show resolved Hide resolved
src/core/symbology/qgssymbollayer.cpp Outdated Show resolved Hide resolved
src/gui/symbology/qgssymbollayerwidget.cpp Outdated Show resolved Hide resolved
@nirvn nirvn merged commit b2e7121 into qgis:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Symbology Related to vector layer symbology or renderers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants