-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE][symbology] Add density-based point count for the random marker fill #32456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
added
Requires Tests!
Waiting on the submitter to add unit tests before eligible for merging
Symbology
Related to vector layer symbology or renderers
labels
Oct 28, 2019
@nyalldawson , I wasn't so sure of the newly-added function wording, feel free to suggest better alternatives if you can think of any. I'll add tests once the code is reviewed. |
roya0045
reviewed
Oct 28, 2019
nyalldawson
reviewed
Oct 29, 2019
nirvn
added
Feature
and removed
Requires Tests!
Waiting on the submitter to add unit tests before eligible for merging
labels
Oct 29, 2019
@nyalldawson , your comments have been addressed, and a test added. |
nyalldawson
reviewed
Oct 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there!
nyalldawson
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a density-based point count method to @nyalldawson 's brand new random marker fill.
GIF time:
Edit: i should probably expand a little bit more here. The benefit of this new method is that contrary to an absolute count, the fill density will remain the same on different scale / zoom levels (as demonstrated in the GIF above).
Checklist
Fixes #11111
at the bottom of the commit messagescripts/prepare-commit.sh
script before each commit