Fixes for handling manual coordinate operations specified in projects #33370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from the proj string via the transform context This isn't possible -- only proj coordinate operations constructed from a src/dest CRS pair can be normalized, not those constructed from a proj string. It was redundant in any case, since we always normalize the available operations before giving users a choice of them. So just add some big bold warnings to the dox in case anyone is manually manipulating and adding custom operations, that these also MUST be pre-normalized Refs qgis#33121, conversation in OSGeo/PROJ#1794
actually being used by a QgsCoordinateTransform object
by QgsCoordinateTransformContext.calculateCoordinateOperation corresponds to the reverse of what's actually required. Gross API, but it's the best we can do until proj has a method to invert a coordinate operation so that we can return the proper inverse operation proj string from calculateCoordinateOperation (without resorting to fragile proj string parsing/mangling)
PROJ 6+ build and a project has manual coordinate operation pathways set Refs qgis#33121
nyalldawson
added
Needs Backporting
Bug
|
@nyalldawson , that transformation dialog's canvas is perfectly sized for Thailand :) Great work! |
…definition By being more selective about when we force convert to a single crs Fixes qgis#32928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs, and probably fixes, #33121
With this branch, loading the project attached to #33121 results in the following default transformation:
This has been verified upstream at proj as being the correct default transformation result to use in this situation.
If the user manually opts to use an older, deprecated transformation via:
then the result is:
(as desired by the original poster)