Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show dimensions metadata on WMS layer metadata #33539

Merged
merged 4 commits into from
Dec 31, 2019
Merged

Show dimensions metadata on WMS layer metadata #33539

merged 4 commits into from
Dec 31, 2019

Conversation

Samweli
Copy link
Contributor

@Samweli Samweli commented Dec 28, 2019

wms-t_time_layer_metadata_qgis

@Samweli Samweli changed the title Added dimensions metadata on WMS layer metadata Show dimensions metadata on WMS layer metadata Dec 28, 2019
nyalldawson
nyalldawson reviewed Dec 28, 2019
View reviewed changes
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just some very minor readability suggestions here. Loving the documentation improvements you've added here!!

src/providers/wms/qgswmscapabilities.cpp Outdated Show resolved Hide resolved
src/providers/wms/qgswmscapabilities.cpp Outdated Show resolved Hide resolved
src/providers/wms/qgswmscapabilities.cpp Outdated Show resolved Hide resolved
src/providers/wms/qgswmscapabilities.h Outdated Show resolved Hide resolved
src/providers/wms/qgswmscapabilities.h Outdated Show resolved Hide resolved
src/providers/wms/qgswmscapabilities.h Outdated Show resolved Hide resolved
@nyalldawson
Copy link
Collaborator

Thanks @Samweli ! Looks like there's a few merge conflicts here now, can you resolve them?

@Samweli
Copy link
Contributor Author

Samweli commented Dec 30, 2019

Thanks @Samweli ! Looks like there's a few merge conflicts here now, can you resolve them?

Sure @nyalldawson , I have resolved them.

@nyalldawson nyalldawson merged commit bc5275a into qgis:master Dec 31, 2019
@timlinux timlinux mentioned this pull request Jan 6, 2020
Closed
@timlinux timlinux added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Feb 18, 2020
@timlinux timlinux removed the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Samweli @nyalldawson @timlinux @pigreco