drad'n'drop improvents part 2 #34433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
part 2 display the container editor in the right panel this avoids opening a modal dialog a new type of itemData has been added as WidgetType to distinguish them in the available widgets from the containers in the form layout fixes qgis#29063
signedav
approved these changes
Feb 12, 2020
| explicit QgsAttributeFormContainerEdit( QTreeWidgetItem *item, QWidget *parent = nullptr ); | ||
|
|
||
|
|
||
| void updateItemData(); |
There was a problem hiding this comment.
It's in app, I added a short description for the class only
| @@ -941,6 +981,9 @@ QTreeWidgetItem *DnDTree::addItem( QTreeWidgetItem *parent, QgsAttributesFormPro | |||
| case QgsAttributesFormProperties::DnDTreeItemData::HtmlWidget: | |||
| //no icon for HtmlWidget | |||
| break; | |||
|
|
|||
| case QgsAttributesFormProperties::DnDTreeItemData::WidgetType: | |||
There was a problem hiding this comment.
This will never happen since this is all in the other if clause checking for container (old thing I mentioned in the last pr). Maybe you are keeping it for your upcoming implementations.
Anyway, I would check here for WidgetType and add this newItem->setBackground( 0, QBrush( Qt::lightGray ) );
There was a problem hiding this comment.
I will take care of the icons later.
But sadly the svg are missing.
There was a problem hiding this comment.
sorry, the fix for the light gray is coming in next round
timlinux
added
the
Changelog
3nids
added a commit
to qgis/QGIS-Documentation
that referenced
this pull request
Feb 18, 2020
3nids
added a commit
to 3nids/QGIS
that referenced
this pull request
Feb 25, 2020
drad'n'drop improvents part 2
3nids
added a commit
that referenced
this pull request
Mar 12, 2020
* [FEATURE] Merge pull request #34411 from 3nids/dnd_sync_selec improvement of the Drag'n'Drop designer * Merge pull request #34433 from 3nids/dnd_part2 drad'n'drop improvents part 2 * drag'n'drop improvements part 3 (#34479) * drag'n'drop improvements part 3 this completely removes hidden config accessible under double click now a widget groupbox (by opposition to the field config) is shown on top of the right panel * remove assert from a left over (fix crash) (#34503) the assert was copied from other class and I was running with RelWithDebugInfo and not Debug. * Update CMakeLists.txt * Update CMakeLists.txt * move to moc headers * sip include
timlinux
removed
the
Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display the container editor in the right panel
this avoids opening a modal dialog
a new type of itemData has been added as WidgetType
to distinguish them in the available widgets from the containers in the form layout
fixes #29063