Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag'n'drop improvements #34479

Merged
merged 2 commits into from
Feb 14, 2020
Merged

drag'n'drop improvements #34479

merged 2 commits into from
Feb 14, 2020

Conversation

3nids
Copy link
Member

@3nids 3nids commented Feb 14, 2020

part 3

this removes the widget config which was only accessible under double click
now a widget groupbox (by opposition to the field config) is shown on top of the right panel

second fix #29063

field:
image

relation:
image

last bits are the QML and HTML widget also available under double click
the double click is accessible from both trees but isn't saved if it's from the available widgets tree.
this would come as a part 4 hopefully.

part 3

this completely removes hidden config accessible under double click
now a widget groupbox (by opposition to the field config) is shown on top of the right panel
@saberraz
Copy link
Contributor

saberraz commented Feb 14, 2020

Nice work @3nids . The only thing missing now is having a form preview :)

@m-kuhn m-kuhn closed this Feb 14, 2020
@m-kuhn m-kuhn reopened this Feb 14, 2020
Copy link
Member

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@@ -0,0 +1,87 @@
/***************************************************************************
qgsattributewidgetedit.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call it form widget (since these are not for attributes only)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave it as since it's named accordingly to the others (like the relation edit)

@3nids
Copy link
Member Author

3nids commented Feb 14, 2020

The only thing missing now is having a form preview :)

@saberraz on the todo list :)

@3nids 3nids merged commit 9441fcc into qgis:master Feb 14, 2020
@3nids 3nids deleted the dnd_part3 branch February 14, 2020 22:20
@obrix
Copy link

obrix commented Feb 17, 2020

Hi @3nids , I am testing master right now and it seems I have some random crash I linked to your last commit :

Fatal: ASSERT: "itemData.type() == QgsAttributesFormProperties::DnDTreeItemData::Container" in file /home/bertrand/Work/fork/QGIS/src/app/attributeformconfig/qgsattributewidgetedit.cpp, line 28
QGIS died on signal -1Could not attach to process.  If your uid matches the uid of the target

It happens when I click on fields on the available widget column or form layout column. Sometimes it crashes and sometimes it does not. Is something missing ?

@3nids
Copy link
Member Author

3nids commented Feb 17, 2020

@obrix can you check if it's crashing only for containers (group box and tabs)?

@3nids
Copy link
Member Author

3nids commented Feb 17, 2020

should be fixed in #34503

@obrix
Copy link

obrix commented Feb 18, 2020

I confirm its fixed. Thanks.

3nids added a commit to qgis/QGIS-Documentation that referenced this pull request Feb 18, 2020
3nids added a commit to 3nids/QGIS that referenced this pull request Feb 25, 2020
* drag'n'drop improvements

part 3

this completely removes hidden config accessible under double click
now a widget groupbox (by opposition to the field config) is shown on top of the right panel
3nids added a commit that referenced this pull request Mar 12, 2020
* [FEATURE] Merge pull request #34411 from 3nids/dnd_sync_selec

improvement of the Drag'n'Drop designer

* Merge pull request #34433 from 3nids/dnd_part2

drad'n'drop improvents part 2

* drag'n'drop improvements part 3 (#34479)

* drag'n'drop improvements

part 3

this completely removes hidden config accessible under double click
now a widget groupbox (by opposition to the field config) is shown on top of the right panel

* remove assert from a left over (fix crash) (#34503)

the assert was copied from other class and I was running with RelWithDebugInfo and not Debug.

* Update CMakeLists.txt

* Update CMakeLists.txt

* move to moc headers

* sip include
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A more intuitive way to open the group/tab properties in drag and drop form designer
4 participants