-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drag'n'drop improvements #34479
drag'n'drop improvements #34479
Conversation
part 3 this completely removes hidden config accessible under double click now a widget groupbox (by opposition to the field config) is shown on top of the right panel
Nice work @3nids . The only thing missing now is having a form preview :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@@ -0,0 +1,87 @@ | |||
/*************************************************************************** | |||
qgsattributewidgetedit.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd call it form widget (since these are not for attributes only)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave it as since it's named accordingly to the others (like the relation edit)
@saberraz on the todo list :) |
Hi @3nids , I am testing master right now and it seems I have some random crash I linked to your last commit :
It happens when I click on fields on the available widget column or form layout column. Sometimes it crashes and sometimes it does not. Is something missing ? |
@obrix can you check if it's crashing only for containers (group box and tabs)? |
should be fixed in #34503 |
I confirm its fixed. Thanks. |
* drag'n'drop improvements part 3 this completely removes hidden config accessible under double click now a widget groupbox (by opposition to the field config) is shown on top of the right panel
* [FEATURE] Merge pull request #34411 from 3nids/dnd_sync_selec improvement of the Drag'n'Drop designer * Merge pull request #34433 from 3nids/dnd_part2 drad'n'drop improvents part 2 * drag'n'drop improvements part 3 (#34479) * drag'n'drop improvements part 3 this completely removes hidden config accessible under double click now a widget groupbox (by opposition to the field config) is shown on top of the right panel * remove assert from a left over (fix crash) (#34503) the assert was copied from other class and I was running with RelWithDebugInfo and not Debug. * Update CMakeLists.txt * Update CMakeLists.txt * move to moc headers * sip include
part 3
this removes the widget config which was only accessible under double click
now a widget groupbox (by opposition to the field config) is shown on top of the right panel
second fix #29063
field:
relation:
last bits are the QML and HTML widget also available under double click
the double click is accessible from both trees but isn't saved if it's from the available widgets tree.
this would come as a part 4 hopefully.