GDAL: make sure we are not reading outside the raster #34460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpaso
added
Rasters
|
Lgtm |
... raster bounds. Fixes qgis#34435 Unfortunately I wasn't able to write a test for this case: it seems to be related to a very rare combination of floating point (double) rounding issues that I could only reproduce manually. But since I was trying to test it and I wrote some raster block test cases, I thought it would be good to leave them in the PR instead of throwing them away.
to be consistent to what happens in the CPU path
elpaso
force-pushed
the
bugfix-gh34435-raster-last-row-error
branch
from
80a1be8
to
aa47fe3
Compare
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_10 release-3_10
# Navigate to the new working tree
cd .worktrees/backport-release-3_10
# Create a new branch
git switch --create backport-34460-to-release-3_10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick fc6e453385b0e200d8edc105426525d1387d43ad
# Push it to GitHub
git push --set-upstream origin backport-34460-to-release-3_10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_10Then, create a pull request where the |
elpaso
added a commit
to elpaso/QGIS
that referenced
this pull request
Feb 17, 2020
…row-error GDAL: make sure we are not reading outside the raster
nyalldawson
pushed a commit
that referenced
this pull request
Feb 17, 2020
…error GDAL: make sure we are not reading outside the raster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34435
Unfortunately I wasn't able to write a test for this
case: it seems to be related to a very rare combination
of floating point (double) rounding issues that I could
only reproduce manually.
But since I was trying to test it and I wrote some
raster block test cases, I thought it would be good
to leave them in the PR instead of throwing them
away.
The changes in the raster calculator are not strictly related
but they make the GPU and CPU path behave the same as
far as nodata are concerned, as was pointed out in
#34435, the behavior was different (the CPU path was the
good one).