Fixes the activation of the shape map tools when digitizing is finished #34905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbartoletti
added
backport release-3_10
Bug
|
Thanks for the fix and the description. Good for me. However, I noticed all the map tools share lots of code in common. At least for the right button handling, isn't there a way to factor a bit ? |
lbartoletti
force-pushed
the
fix_shape_maptool_activation
branch
from
10ad604
to
9984f67
Compare
Done, with a tiny refacto. I'll look for a better replacement of these tools later. |
…ed. Fixes qgis#25168 The digitizing logic for these tools is to deactivate them when digitizing is complete (right-click). However, the tool remains active, but the icon is not pushed in, and the Advanced Digitizing Tool is not active. To fix it, activate the tool again.
lbartoletti
force-pushed
the
fix_shape_maptool_activation
branch
from
9984f67
to
a9f8f2c
Compare
|
@lbartoletti Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The digitizing logic for these tools is to deactivate them when digitizing is complete (right-click). However, the tool remains active, but the icon is not pushed in, and the Advanced Digitizing Tool is not active. To fix it, activate the tool again.