Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests][Server] WMS GetPrint group #35277

Merged
merged 3 commits into from Apr 22, 2020

Conversation

rldhont
Copy link
Contributor

@rldhont rldhont commented Mar 23, 2020

Description

Add WMS GetPrint group test.

@rldhont rldhont added Server testsuite labels Mar 23, 2020
@rldhont rldhont added this to the 3.14.0 milestone Mar 23, 2020
@rldhont
Copy link
Contributor Author

rldhont commented Mar 23, 2020

Try to fix #35107

@rldhont rldhont added the Regression label Mar 24, 2020
@rldhont
Copy link
Contributor Author

rldhont commented Mar 24, 2020

I have ran the test on branch release-3_4 and it passes. So it is a regression.

@rldhont
Copy link
Contributor Author

rldhont commented Mar 24, 2020

WMS_GetPrint_Group_Rendered

The rendered image seems to display all layers and not only the layers in the group

WMS_GetPrint_Group

@nyalldawson
Copy link
Collaborator

nyalldawson commented Mar 24, 2020

@rldhont sounds like #35203 ?

@rldhont
Copy link
Contributor Author

rldhont commented Mar 25, 2020

@nyalldawson how #35203 has been fixed ?

@nyalldawson
Copy link
Collaborator

nyalldawson commented Mar 25, 2020

Yes. But it requires projects to be re-saved to apply the fix

@rldhont
Copy link
Contributor Author

rldhont commented Mar 26, 2020

@nyalldawson you mean the fix is in the QGIS XML Project ?

@nyalldawson
Copy link
Collaborator

nyalldawson commented Mar 26, 2020

@rldhont

you mean the fix is in the QGIS XML Project ?

yes - the issue was caused in projects saved in a limited window of QGIS versions, after #33099 was applied and before #34794 was merged. The only solution is to load the project post #34794, fix the theme, and resave.

@rldhont
Copy link
Contributor Author

rldhont commented Mar 27, 2020

@nyalldawson There are no themes in the test project, and I found something was missing in the code.

@rldhont rldhont force-pushed the server-wms-getprint-group-layer branch 2 times, most recently from a7e288d to 578b2cd Compare Apr 3, 2020
@rldhont
Copy link
Contributor Author

rldhont commented Apr 9, 2020

@dmarteau @elpaso @pblottiere can you help me to fix this issue. I have probably found where the issue comes from but my fix segfault.

@rldhont rldhont force-pushed the server-wms-getprint-group-layer branch from 28e4335 to 8797751 Compare Apr 19, 2020
@rldhont
Copy link
Contributor Author

rldhont commented Apr 20, 2020

@pblottiere I have found the commit that create the regression 5c874ca

This commit removes QgsRenderer::stylizedLayers in which groups nickname is transformed into a QgsMapLayer list. Can you take a look at my fix ?

@pblottiere
Copy link
Member

pblottiere commented Apr 20, 2020

Hi @rldhont,

Can you take a look at my fix ?

The rationale looks good. Waiting for Travis then 🤞

@rldhont
Copy link
Contributor Author

rldhont commented Apr 22, 2020

@pblottiere thanks for the review

@rldhont
Copy link
Contributor Author

rldhont commented Apr 22, 2020

Yeah travis is happy

@rldhont rldhont force-pushed the server-wms-getprint-group-layer branch from 97fafff to a06984c Compare Apr 22, 2020
@rldhont rldhont merged commit a48474d into qgis:master Apr 22, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression Server testsuite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants