[vector] Remove problematic topological editing related assert when adding features #35622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
added
Bug
|
For me, yes. @lbartoletti you seem to have added these checks in #32474 , how do you feel about it? |
|
@lbartoletti , all good with removing the assert? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So it turns out there are more scenarios where the assert check is bogus. Other than a newly-created polygon having nb of vertices entered + 1 as its final nb of geometry vertices, the count also doesn't match when a newly added polygon as clipped when [x] avoid overlap is active.
The more I've gotten to familiarize myself with the code here, the more I think this assert should simply go away.
@m-kuhn , all good?