Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MESH][FEATURE] update to MDAL 0.5.91 Multi meshes in one file #35669

Merged
merged 5 commits into from Apr 14, 2020
Merged

[MESH][FEATURE] update to MDAL 0.5.91 Multi meshes in one file #35669

merged 5 commits into from Apr 14, 2020

Conversation

vcloarec
Copy link
Member

@vcloarec vcloarec commented Apr 8, 2020

In addition of updating to MDAL 0.5.91, this PR allows to load several meshes from one file.
The file is parsed and a sub layer dialog is launched as the same logic than vector layers or raster layers.
multimesh

@github-actions github-actions bot added this to the 3.14.0 milestone Apr 8, 2020
@vcloarec vcloarec closed this Apr 8, 2020
@vcloarec vcloarec reopened this Apr 8, 2020
PeterPetrik
PeterPetrik reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already reviewed in vcloarec#13 and happy with the implementation

@PeterPetrik PeterPetrik self-requested a review April 9, 2020 13:39
@PeterPetrik PeterPetrik added Changelog Items that are queued to appear in the visual changelog - remove after harvesting Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. labels Apr 14, 2020
@qgis-bot
Copy link
Collaborator

@vcloarec
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@PeterPetrik PeterPetrik merged commit 17a95ef into qgis:master Apr 14, 2020
@qgis-bot qgis-bot mentioned this pull request Apr 14, 2020
Closed
@qgis-bot
Copy link
Collaborator

@vcloarec
A documentation ticket has been opened at qgis/QGIS-Documentation#5279
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@pigreco pigreco added Feature Mesh Related to general mesh layer handling (not specific data formats) labels May 22, 2020
@timlinux timlinux removed the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterPetrik PeterPetrik PeterPetrik approved these changes

Assignees
No one assigned
Labels
Feature Mesh Related to general mesh layer handling (not specific data formats) Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vcloarec @qgis-bot @PeterPetrik @timlinux @pigreco