Offer a per feature, as well as a global minimum distance parameter, for the Random points on lines algorithm #35793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havatv
commented
Apr 15, 2020
It is ridiculous to have to change this.
nyalldawson
approved these changes
Apr 19, 2020
|
Thanks, @nyalldawson! I will update the documentation. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"Splits" the Minimum distance between points parameter into Minimum distance between points (per feature) and Global minimum distance between points. The last one can not be data-defined, since it would be strange to have a global parameter change on a per feature basis.
The split is important, because it makes it possible to apply the minimum distance only "locally" (for each feature), meaning that points added to features close by are not considered when checking minimum distance (only the points added for the current line feature are checked).
It is meaningful to combine the two minimum distance parameters, but if the global one is larger than the local one, the local one will have no effect.
New tests have been added, and the existing ones have been updated to reflect the change.