[MESH] fix streamlines and traces renderer when vector is null #36633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcloarec
added
Bug
PeterPetrik
reviewed
May 22, 2020
| @@ -550,6 +550,9 @@ void QgsMeshLayerRenderer::renderVectorDataset() | |||
| if ( std::isnan( mVectorDatasetMagMinimum ) || std::isnan( mVectorDatasetMagMaximum ) ) | |||
| return; // only NODATA values | |||
|
|
|||
| if ( !( mVectorDatasetMagMaximum > 0 ) ) | |||
There was a problem hiding this comment.
mVectorDatasetMagMaximum <= 0
There was a problem hiding this comment.
Indeed, I hesitated, but I found more explicit >0
| @@ -429,6 +430,9 @@ void QgsMeshStreamField::addTrace( QPoint startPixel ) | |||
| if ( !mVectorValueInterpolator ) | |||
| return; | |||
|
|
|||
| if ( !( mMaximumMagnitude > 0 ) ) | |||
There was a problem hiding this comment.
mVectorDatasetMagMaximum <= 0
|
I found this issue without ticket during temporal tries. Maybe fix #35888, but very not sure. |
|
related #35888 |
|
Merged the ticket, I have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mesh rendering, the streamlines and the trace renderers didn't stop when vector magnitude was null.
This PR fix this issue